From 67a859622eebcf2a497e508801caf43226990dcf Mon Sep 17 00:00:00 2001 From: Oussama Saoudi Date: Thu, 19 Dec 2024 16:36:28 -0800 Subject: [PATCH] address issues --- kernel/tests/cdf.rs | 7 +++---- kernel/tests/common/mod.rs | 2 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/tests/cdf.rs b/kernel/tests/cdf.rs index 0ed3402f7..45f48c608 100644 --- a/kernel/tests/cdf.rs +++ b/kernel/tests/cdf.rs @@ -329,8 +329,9 @@ fn simple_cdf_version_ranges() -> DeltaResult<()> { #[test] fn update_operations() -> DeltaResult<()> { let batches = read_cdf_for_table("cdf-table-update-ops", 0, 2, None)?; - // Note: `update_pre` and `update_post` are technically not part of the delta spec, but are - // part of the tests used in delta + // Note: `update_pre` and `update_post` are technically not part of the delta spec, and instead + // should be `update_preimage` and `update_postimage` respectively. However, the tests in + // delta-spark use the post and pre. let mut expected = vec![ "+----+--------------+-----------------+", "| id | _change_type | _commit_version |", @@ -365,8 +366,6 @@ fn update_operations() -> DeltaResult<()> { #[test] fn false_data_change_is_ignored() -> DeltaResult<()> { let batches = read_cdf_for_table("cdf-table-data-change", 0, 1, None)?; - // Note: `update_pre` and `update_post` are technically not part of the delta spec, but are - // part of the tests used in delta let mut expected = vec![ "+----+--------------+-----------------+", "| id | _change_type | _commit_version |", diff --git a/kernel/tests/common/mod.rs b/kernel/tests/common/mod.rs index 3ae0056b8..a918695b7 100644 --- a/kernel/tests/common/mod.rs +++ b/kernel/tests/common/mod.rs @@ -46,11 +46,9 @@ pub(crate) fn load_test_data( test_name: &str, ) -> Result> { let path = format!("{test_parent_dir}/{test_name}.tar.zst"); - println!("Path: {path}"); let tar = zstd::Decoder::new(std::fs::File::open(path)?)?; let mut archive = tar::Archive::new(tar); let temp_dir = tempfile::tempdir()?; - println!("dir : {:?}", temp_dir.path()); archive.unpack(temp_dir.path())?; Ok(temp_dir) }