Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HDFS via hdfs-native-object-store package #274

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

SchutteJan
Copy link
Contributor

@SchutteJan SchutteJan commented Jul 9, 2024

closes #266

I've been able to verify this implementation works using the kernel examples. I am not sure what can be added in terms of tests, let me know if anything there is needed.

I've ran my tests using the MiniDfs implementation from hdfs-native, see example here:
https://github.com/Kimahriman/hdfs-native/blob/ebb5a2f98ab9fe487091403f45324650e3cd65fb/rust/examples/simple.rs

With MiniDFS running:

$ cd kernel/examples/read-table-multi-threaded/
$ cargo run hdfs://localhost:9000/my_delta_table/
Reading hdfs://localhost:9000/my_delta_table/
+----+-------+
| id | value |
+----+-------+
| 1  | foo   |
| 2  | boo   |
+----+-------+

@SchutteJan SchutteJan marked this pull request as ready for review July 11, 2024 15:36
@SchutteJan SchutteJan changed the title Support HDFS via hdfs-native package Support HDFS via hdfs-native-object-store package Jul 11, 2024
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing thanks!

couple of small things but looks solid.

kernel/Cargo.toml Outdated Show resolved Hide resolved
kernel/src/engine/default/storage.rs Show resolved Hide resolved
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one small request to put the cargo command for the test as a comment in the test file

kernel/src/engine/default/storage.rs Show resolved Hide resolved
Copy link
Collaborator

@hntd187 hntd187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had some minor fixes I'd like.

kernel/tests/hdfs.rs Outdated Show resolved Hide resolved
kernel/Cargo.toml Show resolved Hide resolved
kernel/src/engine/default/storage.rs Outdated Show resolved Hide resolved
@hntd187 hntd187 merged commit 48f3c11 into delta-io:main Jul 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support HDFS via hdfs-native package
3 participants