-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HDFS via hdfs-native-object-store package #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing thanks!
couple of small things but looks solid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just one small request to put the cargo command for the test as a comment in the test file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just had some minor fixes I'd like.
closes #266
I've been able to verify this implementation works using the kernel examples. I am not sure what can be added in terms of tests, let me know if anything there is needed.
I've ran my tests using the MiniDfs implementation from
hdfs-native
, see example here:https://github.com/Kimahriman/hdfs-native/blob/ebb5a2f98ab9fe487091403f45324650e3cd65fb/rust/examples/simple.rs
With MiniDFS running: