From 8eb2b8b611ce4f8cdfd24d3ae5ff52332628188f Mon Sep 17 00:00:00 2001 From: "R. Tyler Croy" Date: Fri, 17 May 2024 19:25:46 +0000 Subject: [PATCH] chore: fixing some clips --- crates/aws/src/storage.rs | 1 - crates/core/src/delta_datafusion/expr.rs | 8 ++++---- crates/core/src/operations/set_tbl_properties.rs | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/crates/aws/src/storage.rs b/crates/aws/src/storage.rs index c12151089f..e7b4d71109 100644 --- a/crates/aws/src/storage.rs +++ b/crates/aws/src/storage.rs @@ -21,7 +21,6 @@ use std::str::FromStr; use std::sync::Arc; use std::time::Duration; use tokio::io::AsyncWrite; -use tracing::warn; use url::Url; use crate::errors::DynamoDbConfigError; diff --git a/crates/core/src/delta_datafusion/expr.rs b/crates/core/src/delta_datafusion/expr.rs index 5b62726611..868969c571 100644 --- a/crates/core/src/delta_datafusion/expr.rs +++ b/crates/core/src/delta_datafusion/expr.rs @@ -372,8 +372,8 @@ impl<'a> fmt::Display for ScalarValueFormat<'a> { Some(e) => write!( f, "'{}'::date", - DateTime::from_timestamp_millis((*e).into()) - .ok_or(Error::default())? + DateTime::from_timestamp_millis(*e) + .ok_or(Error)? .date_naive() .format("%Y-%m-%d") )?, @@ -385,14 +385,14 @@ impl<'a> fmt::Display for ScalarValueFormat<'a> { f, "arrow_cast('{}', 'Timestamp(Microsecond, Some(\"UTC\"))')", DateTime::from_timestamp_micros(*e) - .ok_or(Error::default())? + .ok_or(Error)? .format("%Y-%m-%dT%H:%M:%S%.6f") )?, None => write!( f, "arrow_cast('{}', 'Timestamp(Microsecond, None)')", DateTime::from_timestamp_micros(*e) - .ok_or(Error::default())? + .ok_or(Error)? .format("%Y-%m-%dT%H:%M:%S%.6f") )?, }, diff --git a/crates/core/src/operations/set_tbl_properties.rs b/crates/core/src/operations/set_tbl_properties.rs index f275455158..b7e9992b1f 100644 --- a/crates/core/src/operations/set_tbl_properties.rs +++ b/crates/core/src/operations/set_tbl_properties.rs @@ -262,7 +262,7 @@ impl std::future::IntoFuture for SetTablePropertiesBuilder { type IntoFuture = BoxFuture<'static, Self::Output>; fn into_future(self) -> Self::IntoFuture { - let mut this = self; + let this = self; Box::pin(async move { let mut metadata = this.snapshot.metadata().clone();