fix: azure sas key url encoding

delta-io · Dec 21, 2022 · d5745da · d5745da
1 parent 28d4aa3
commit d5745da
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/rust/src/builder/azure.rs b/rust/src/builder/azure.rs
@@ -5,6 +5,7 @@ use crate::DeltaResult;
 
 use object_store::azure::MicrosoftAzureBuilder;
 use once_cell::sync::Lazy;
+use percent_encoding::percent_decode_str;
 
 #[derive(PartialEq, Eq)]
 enum AzureConfigKey {
@@ -220,6 +221,9 @@ fn parse_boolean(term: &str) -> Option<bool> {
 }
 
 fn split_sas(sas: &str) -> Result<Vec<(String, String)>, BuilderError> {
+    let sas = percent_decode_str(sas)
+        .decode_utf8()
+        .map_err(|err| BuilderError::Decode(err.to_string()))?;
     let kv_str_pairs = sas
         .trim_start_matches('?')
         .split('&')

diff --git a/rust/src/builder/mod.rs b/rust/src/builder/mod.rs
@@ -37,6 +37,8 @@ enum BuilderError {
     Required(String),
     #[error("Failed to find valid credential.")]
     MissingCredential,
+    #[error("Failed to decode sas key. {0}")]
+    Decode(String),
 }
 
 impl From<BuilderError> for DeltaTableError {