Skip to content

Commit

Permalink
chore: clean up some compilation failures and un-ignore some tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rtyler committed Mar 5, 2024
1 parent 8b601ab commit dadefc3
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion crates/core/src/kernel/models/schema.rs
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ mod tests {
use super::*;
use serde_json;
use serde_json::json;
use std::hash::DefaultHasher;
use std::collections::hash_map::DefaultHasher;

#[test]
fn test_serde_data_types() {
Expand Down
2 changes: 0 additions & 2 deletions crates/core/src/kernel/snapshot/log_segment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -515,8 +515,6 @@ pub(super) async fn list_log_files(

#[cfg(test)]
pub(super) mod tests {
use std::str::FromStr;

use deltalake_test::utils::*;

use super::*;
Expand Down
2 changes: 1 addition & 1 deletion crates/core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
//! # Querying Delta Tables with Datafusion
//!
//! Querying from local filesystem:
//! ```ignore
//! ```
//! use std::sync::Arc;
//! use datafusion::prelude::SessionContext;
//!
Expand Down
2 changes: 1 addition & 1 deletion crates/core/src/operations/convert_to_delta.rs
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ impl ConvertToDeltaBuilder {
}

/// Consume self into CreateBuilder with corresponding add actions, schemas and operation meta
async fn into_create_builder(mut self) -> Result<CreateBuilder, Error> {
async fn into_create_builder(self) -> Result<CreateBuilder, Error> {
// Use the specified log store. If a log store is not provided, create a new store from the specified path.
// Return an error if neither log store nor path is provided
let log_store = if let Some(log_store) = self.log_store {
Expand Down
2 changes: 1 addition & 1 deletion crates/core/src/operations/merge/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,7 @@ async fn execute(
build_case(copy_when, copy_then)?,
));

let mut new_columns = {
let new_columns = {
let plan = projection.into_unoptimized_plan();
let mut fields: Vec<Expr> = plan
.schema()
Expand Down
1 change: 0 additions & 1 deletion crates/core/src/writer/stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,6 @@ mod tests {
}
}

#[ignore]
#[tokio::test]
async fn test_delta_stats() {
let temp_dir = tempfile::tempdir().unwrap();
Expand Down
1 change: 0 additions & 1 deletion crates/core/tests/command_optimize.rs
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,6 @@ async fn test_commit_interval() -> Result<(), Box<dyn Error>> {
}

#[tokio::test]
#[ignore]
/// Validate that bin packing is idempotent.
async fn test_idempotent() -> Result<(), Box<dyn Error>> {
//TODO: Compression makes it hard to get the target file size...
Expand Down

0 comments on commit dadefc3

Please sign in to comment.