-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write_deltalake fails writing a simple dataset with categorical columns #1326
Comments
Related to: #686 |
I think for dictionary types (and other future encoded types, such as REE), we should develop some facility for mapping to a canonical "logical type". So |
When can we expect this to be implemented? |
I tried reproducing the given script, and it no longer errors. It does in fact write out |
So, in some sense this is fixed. However, the ideal would be to preserve categoricals as categoricals, rather than strings. Is there a technical reason this can't be done, or is it just a matter of someone having the time? If the latter, what specifically needs doing? |
This is not possible. Categorical is not a supported primitive type in the delta protocol. If you would like to have it be a supported type, you need to post an RFC in the main delta repo. Only once it's introduced there in the protocol, we can add support |
Thank you, that's good to know. |
Given the reproducer no longer fails, if that matches other people's results then this issue can be closed? |
Environment
Delta-rs version: 0.8.1
Binding: python
Environment:
Bug
What happened:
write_deltalake fails writing a simple dataset with categorical columns
What you expected to happen:
write_deltalake not to fail
How to reproduce it:
Minimal test case to reproduce it:
The text was updated successfully, but these errors were encountered: