Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Min/Max using Delta metadata #1525

Closed
wants to merge 13 commits into from
Closed

Optimize Min/Max using Delta metadata #1525

wants to merge 13 commits into from
+1,178 −226

Commits on Nov 22, 2023

  1. Change tests to compare the results from not optimized path, instead … 

    …of hard coding it

Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    4a3ae3b View commit details
    Browse the repository at this point in the history

  2. Improve unit test setup 

    Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ea937cf View commit details
    Browse the repository at this point in the history

  3. Returns min/max results from Delta Stats. Support Count, Min and Max … 

    …in show(). Disable min/max optimization if table has Deletion Vectors

Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c269974 View commit details
    Browse the repository at this point in the history

  4. Refactor to address PR review 

    Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    61dbdc9 View commit details
    Browse the repository at this point in the history

  5. Aggregates similar tests into a matrix. 

    Add column mapping tests using the existing traits.
Add test using partitioned column filter

Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0bd8be7 View commit details
    Browse the repository at this point in the history

  6. Only extract the columns used in the query and avoids reading partiti… 

    …on values if all values were found in stats

Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    6ba89ce View commit details
    Browse the repository at this point in the history

  7. Extract Count and Min/Max in a single method. Allows to extract Min/M… 

    …ax from partitioned columns even when COUNT is not available

Fix style error

Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2c70c6b View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Add Unit Tests: 

    -table with DVs
-empty table
-table with few AddFiles having zero rows

Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a36413c View commit details
    Browse the repository at this point in the history

  2. Refactor to address PR comments 

    Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    ce394fb View commit details
    Browse the repository at this point in the history

  3. Refactor to address PR comments 2 

    Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    b2b4984 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Refactor to address PR comments 3 

    Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    923c423 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Refactor to address PR comments 4. Collect validation results with op… 

    …timization disabled

Signed-off-by: Felipe Fujiy Pessoto <fepessot@microsoft.com>
    @felipepessoto
    felipepessoto committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3549f63 View commit details
    Browse the repository at this point in the history

  2. import ordering

    @vkorukanti
    vkorukanti committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    42b3edb View commit details
    Browse the repository at this point in the history