-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PURGE to remove DVs from Delta tables #1732
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright (2021) The Delta Lake Project Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.sql.delta.commands | ||
|
||
import org.apache.spark.sql.delta.catalog.DeltaTableV2 | ||
import org.apache.spark.sql.{Row, SparkSession} | ||
import org.apache.spark.sql.catalyst.plans.logical.{IgnoreCachedData, LeafCommand, LogicalPlan, UnaryCommand} | ||
import org.apache.spark.sql.catalyst.TableIdentifier | ||
|
||
case class ReorgTable(target: LogicalPlan)(val predicates: Seq[String]) extends UnaryCommand { | ||
|
||
def child: LogicalPlan = target | ||
|
||
protected def withNewChildInternal(newChild: LogicalPlan): LogicalPlan = | ||
copy(target = newChild)(predicates) | ||
|
||
override val otherCopyArgs: Seq[AnyRef] = predicates :: Nil | ||
} | ||
|
||
/** | ||
* The PURGE command. | ||
*/ | ||
case class ReorgTableCommand(target: DeltaTableV2)(val predicates: Seq[String]) | ||
extends OptimizeTableCommandBase with LeafCommand with IgnoreCachedData { | ||
|
||
override val otherCopyArgs: Seq[AnyRef] = predicates :: Nil | ||
|
||
override def run(sparkSession: SparkSession): Seq[Row] = { | ||
val command = OptimizeTableCommand( | ||
Option(target.path.toString), | ||
target.catalogTable.map(_.identifier), | ||
predicates, | ||
options = Map.empty, | ||
optimizeContext = OptimizeContext( | ||
isPurge = true, | ||
minFileSize = Some(0L), | ||
maxDeletedRowsRatio = Some(0d)) | ||
)(zOrderBy = Nil) | ||
command.run(sparkSession) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the command output expected to be same as the optimize? are the columns same? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, they're the same. The return schema contains two columns, |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because I see other rules do not have spaces around
=
.