Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REORG operation details in commit history #1753

Closed
wants to merge 1 commit into from

Conversation

vkorukanti
Copy link
Collaborator

@vkorukanti vkorukanti commented May 11, 2023

Description

REORG command was added as part of the #1732. The operation is recorded as OPTIMIZE. This PR changes it to REORG

How was this patch tested?

Updated existing UTs to verify the Delta table history

GitOrigin-RevId: 4b3b8d9bc287b6491be50a879f2508e889adeb4b
@vkorukanti
Copy link
Collaborator Author

@xupefei Please review.

.select("operation", "operationParameters", "operationMetrics")
.as[(String, Map[String, String], Map[String, String])]
.head()
assert(opName === "REORG")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we check for opName in the optimize suites?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not. Will followup with a separate PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xupefei
Copy link
Collaborator

xupefei commented May 12, 2023

LGTM, thanks for the work!

Copy link
Collaborator

@allisonport-db allisonport-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

allisonport-db pushed a commit to allisonport-db/delta that referenced this pull request May 16, 2023
`REORG` command was added as part of the delta-io#1732. The operation is recorded as `OPTIMIZE`. This PR changes it to `REORG`

Updated existing UTs to verify the Delta table history

Closes delta-io#1753

Signed-off-by: Venki Korukanti <venki.korukanti@databricks.com>
GitOrigin-RevId: d5d27e6b5710659d3766eed0b0c32ec5b716d644
(cherry picked from commit 9391568)
allisonport-db pushed a commit to allisonport-db/delta that referenced this pull request May 16, 2023
## Description
`REORG` command was added as part of the delta-io#1732. The operation is recorded as `OPTIMIZE`. This PR changes it to `REORG`

Updated existing UTs to verify the Delta table history

Closes delta-io#1753

Signed-off-by: Venki Korukanti <venki.korukanti@databricks.com>
GitOrigin-RevId: d5d27e6b5710659d3766eed0b0c32ec5b716d644
(cherry picked from commit 9391568)
@vkorukanti vkorukanti deleted the purgeOp branch October 2, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants