[Spark] Support show tblproperties and update catalog for clustered table #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zedtang
force-pushed
the
clustered-table-update-catalog
branch
2 times, most recently
from
293547e to
795a95e
Compare
zedtang
force-pushed
the
clustered-table-update-catalog
branch
from
795a95e to
4e65a35
Compare
dabao521
approved these changes
Jun 14, 2024
Comment on lines
+48
to
+50
| // This is necessary because the [[SparkThreadLocalForwardingThreadPoolExecutor]] | ||
| // retains a reference to the SparkContext. Without resetting, the new test suite would | ||
| // reuse the same SparkContext from the previous suite, despite it being stopped. |
There was a problem hiding this comment.
Can we also point out that this is mainly for the UpdateCatalogHook background thread to have a new SparkContext to avoid access-after-stop issue between suites?
There was a problem hiding this comment.
Sure, added a comment.
zedtang
force-pushed
the
clustered-table-update-catalog
branch
from
46f82cc to
8fc040c
Compare
zedtang
force-pushed
the
clustered-table-update-catalog
branch
from
5aee0cd to
97c1ef2
Compare
zedtang
force-pushed
the
clustered-table-update-catalog
branch
from
c4bc884 to
2b5f432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Support show tblproperties for clustered table, and support updating the clustering column properties in the catalog. Remove table properties from describe detail's output since that's using the properties from metadata.
How was this patch tested?
Add verification for table properties, describe detail, and catalog table in verifyClusteringColumns.
Does this PR introduce any user-facing changes?
No