Update to rPGP 0.10 #4236
Merged
Update to rPGP 0.10 #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This adds more duplicate dependencies, mainly because rPGP updated some crypto dependencies while iroh still depends on old versions. |
|
The test This commit is a squashed PR rpgp/rpgp#215. EDIT: I made a fix rpgp/rpgp#231 |
link2xt
force-pushed
the
link2xt/update-rpgp
branch
from
aa6b370
to
bd92140
Compare
link2xt
force-pushed
the
link2xt/update-rpgp
branch
from
c6a0504
to
d5ac5c0
Compare
| { name = "convert_case", version = "0.4.0" }, | ||
| { name = "darling", version = "<0.14" }, | ||
| { name = "convert_case", version = "0.4.0" }, | ||
| { name = "curve25519-dalek", version = "3.2.0" }, |
There was a problem hiding this comment.
what still pulls this in? this shouldn't be in the dep tree anymore
There was a problem hiding this comment.
cargo tree -i curve25519-dalek@3.2.0 output:
curve25519-dalek v3.2.0
├── ed25519-dalek v1.0.1
│ ├── iroh v0.4.0
│ │ └── deltachat v1.112.3 (/home/user/src/deltachat/deltachat-core-rust)
│ └── ssh-key v0.5.1
│ └── iroh v0.4.0 (*)
└── x25519-dalek v2.0.0-pre.1
└── pgp v0.10.1
└── deltachat v1.112.3 (/home/user/src/deltachat/deltachat-core-rust)
There was a problem hiding this comment.
oh lol, okay iroh will upgrade, but we still need some deps to be released first, so I guess we have to accept the duplicate deps for the moment.
dignifiedquire
approved these changes
Mar 30, 2023
link2xt
force-pushed
the
link2xt/update-rpgp
branch
from
d5ac5c0
to
4f63325
Compare
link2xt
force-pushed
the
link2xt/update-rpgp
branch
from
4f63325
to
3e65b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases MSRV to 1.65.0, so blocked by deltachat/deltachat-ios#1771
And we need to merge deltachat/deltachat-android#2494 first, but this can be done right after releasing Delta Chat Android 1.36.