9 - emergencyWithdraw override function to withdraw funds after strategy shutdown #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strategy shutdown
mcclurejt
changed the title
mcclurejt
changed the title
MrToph
reviewed
Dec 21, 2024
| /// likelihood of reverts. | ||
| function _emergencyWithdraw(uint256) internal override { | ||
| IEverlongStrategy.EverlongPosition memory position; | ||
| while (!_portfolio.isEmpty()) { |
There was a problem hiding this comment.
there might be a lot of open positions and closing them is not cheap. worst case, you can't fit them in a single block. consider just closing positions until at least amount parameter is reached (can still fully close the individual positions, something like while (!empty && closed < amount) { ... closed += bondAmount }. And then change the natspec that amount is actually a bond amount).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements the
_emergencyWithdrawstrategy hook so that funds can be withdrawn when the strategy is shut down.The hook transfers all hyperdrive long tokens to the trusted
Emergency Adminaddress so that they can be closed and the proceeds transferred back to the strategy.issue