From 2e2ef61f8ebac7d35f7cbb981ad0769152bd9025 Mon Sep 17 00:00:00 2001 From: Chris DeMartini Date: Tue, 12 May 2020 00:32:08 -0700 Subject: [PATCH 1/2] chore: version bump for latest changes --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 4f4aed1..99c4f96 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "tableau-semiotic-hierarchy", - "version": "1.0.0", + "version": "1.0.1", "homepage": "https://demartsc.github.io/tableau-semiotic-hierarchy", "private": true, "dependencies": { From e1ef4d729d4365cef25b0ea07f47a4114bbc3ec4 Mon Sep 17 00:00:00 2001 From: Chris DeMartini Date: Tue, 12 May 2020 21:41:11 -0700 Subject: [PATCH 2/2] fix: interactivity bug --- src/App.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/App.js b/src/App.js index 28390e7..60cbc17 100644 --- a/src/App.js +++ b/src/App.js @@ -279,7 +279,7 @@ class App extends Component { // clickAction ); - this.applyMouseActionsToSheets(d, clickAction, getConfigFieldInternalName(clickField, this.state.tableauSettings)); + this.applyMouseActionsToSheets(d, clickAction, clickField); }; emptyClickCallBack = d => { @@ -291,7 +291,7 @@ class App extends Component { d, ); - this.applyMouseActionsToSheets(undefined, clickAction, getConfigFieldInternalName(clickField, this.state.tableauSettings)); + this.applyMouseActionsToSheets(undefined, clickAction, clickField); }; hoverCallBack = d => { @@ -308,7 +308,7 @@ class App extends Component { ); // if we are actually hovering on something then we should call this function - this.applyMouseActionsToSheets(d, hoverAction, getConfigFieldInternalName(hoverField, this.state.tableauSettings)); + this.applyMouseActionsToSheets(d, hoverAction, hoverField); } applyMouseActionsToSheets = (d, action, fieldName) => { @@ -335,13 +335,13 @@ class App extends Component { if ( d ) { // select marks or filter const actionToApply = toHighlight ? selectMarksByField : applyFilterByField; - tasks.push(actionToApply(mappedFieldName, [d[mappedFieldName]], ConfigSheet)); - // log('we are applyMouseActionsToSheets', d, action, fieldName, ConfigSheet, toHighlight, toFilter, d[fieldName], actionToApply); + tasks.push(actionToApply(fieldName, [d[mappedFieldName]], ConfigSheet)); + // log('we are applyMouseActionsToSheets', d, action, fieldName, mappedFieldName, ConfigSheet, toHighlight, toFilter, d[mappedFieldName], actionToApply); } else { // clear marks or filer const actionToApply = toHighlight ? clearMarksByField : clearFilterByField; - tasks.push(actionToApply(mappedFieldName, ConfigSheet)); + tasks.push(actionToApply(fieldName, ConfigSheet)); } Promise.all(tasks).then(() => {