[Marketplace Contribution] Content Testing - Content Pack Update #26088

xsoar-bot · 2023-04-25T13:57:09Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Contributor

Notes

fix to support XSOAR 8.2
change line 94 from 'args': {}, to 'args': newargs,

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

merit-maita

thank you for your contribution!
please make sure to add RN, and can you please explain to me what do the changes you made actually do? like why newargs and what you mean by to support xsoar 8.2? which change is related to that?

merit-maita · 2023-04-30T10:39:16Z

Packs/ContentTesting/ReleaseNotes/1_1_2.md

+
+##### UnitTest
+
+- %%UPDATE_RN%%


can you add release note explaining what you did please

rurhrlaub · 2023-05-01T13:17:34Z

Hmmm. I updated the RN during the submission. I updated them in git: #### Scripts ##### UnitTest - Change line 93 from 'args':{}, 'args': newargs, - Updated the Docker image to: *demisto/python3:3.10.11.55362*.

…

On Sun, Apr 30, 2023 at 5:47 AM merit-maita ***@***.***> wrote: ***@***.**** commented on this pull request. thank you for your contribution! please make sure to add RN, and can you please explain to me what do the changes you made actually do? like why newargs and what you mean by to support xsoar 8.2? which change is related to that? ------------------------------ In Packs/ContentTesting/ReleaseNotes/1_1_2.md <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_26088-23discussion-5Fr1181207155&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=RNv9xlFD9EehnEYwARn5LXbwQadPt8vm9h4zlEqeEDm3aFHXwCicjciColqay1KE&s=QdUSuzYDY6qlVrzeWt2pG40t3dXbjCS2F2ks2-BGFkk&e=> : > @@ -0,0 +1,7 @@ + +#### Scripts + +##### UnitTest + +- %%UPDATE_RN%% can you add release note explaining what you did please — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_26088-23pullrequestreview-2D1407090458&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=RNv9xlFD9EehnEYwARn5LXbwQadPt8vm9h4zlEqeEDm3aFHXwCicjciColqay1KE&s=zLRk0oK0eYT8FbvuV0IZVgbm5yTBqBAIdmubSJLo-TU&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVTN25SDP5IILM535MYXARTXDY7NVANCNFSM6AAAAAAXLBQ34I&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=RNv9xlFD9EehnEYwARn5LXbwQadPt8vm9h4zlEqeEDm3aFHXwCicjciColqay1KE&s=U0qp8GuimJiOg2XYh5D1dGfiWBmtXsdPxzaS8o6uVNg&e=> . You are receiving this because you were mentioned.Message ID: ***@***.***>

merit-maita

i reviewed your RN, please answer my question there in order to make the correct required RN.
thanks!

merit-maita · 2023-05-02T10:25:28Z

Packs/ContentTesting/ReleaseNotes/1_1_2.md

+
+##### UnitTest
+
+- Change line 93 from      'args':{},                      'args': newargs, 


if the change being made does not have any visible impact on the user, then the note should be 'Documentation and metadata improvements.', but i need to understand, what is the purpose of this change? and what is to support xsoar 8.2 you mentioned in the description

rurhrlaub · 2023-05-02T13:19:03Z

In 8.2, it would fail with an error and all the arguments were blank. I do not know why this behavior is different compared to 6.x

…

On Tue, May 2, 2023 at 5:26 AM merit-maita ***@***.***> wrote: ***@***.**** commented on this pull request. i reviewed your RN, please answer my question there in order to make the correct required RN. thanks! ------------------------------ In Packs/ContentTesting/ReleaseNotes/1_1_2.md <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_26088-23discussion-5Fr1182368150&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=fmIyPI92jYoLqtULmoVnrL1-XMBuvZb_Fjz07JNWdbw11OMg9liAx6BlI_IACgA_&s=Ji6MSSDod2-PX3yy76Lhgbbk8HCl7EZdF5c08iVxJjg&e=> : > @@ -0,0 +1,7 @@ + +#### Scripts + +##### UnitTest + +- Change line 93 from 'args':{}, 'args': newargs, if the change being made does not have any visible impact on the user, then the note should be 'Documentation and metadata improvements.', but i need to understand, what is the purpose of this change? and what is to support xsoar 8.2 you mentioned in the description — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_26088-23pullrequestreview-2D1408826795&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=fmIyPI92jYoLqtULmoVnrL1-XMBuvZb_Fjz07JNWdbw11OMg9liAx6BlI_IACgA_&s=GsG0eZvqcBnEQ10xlDq4HWmMKfVC3aqNR_QRvtaHJwQ&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVTN25UW6YZH2QM3ZZR6IEDXEDONZANCNFSM6AAAAAAXLBQ34I&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=fmIyPI92jYoLqtULmoVnrL1-XMBuvZb_Fjz07JNWdbw11OMg9liAx6BlI_IACgA_&s=ehkvXimjylrgjJsABbiMz784cmMZpCejE1tEgU82OzI&e=> . You are receiving this because you were mentioned.Message ID: ***@***.***>

merit-maita

please change the RN to the suggestion i gave.

merit-maita · 2023-05-03T11:05:29Z

Packs/ContentTesting/ReleaseNotes/1_1_2.md

+
+##### UnitTest
+
+- Change line 93 from      'args':{},                      'args': newargs, 


Suggested change

- Change line 93 from 'args':{}, 'args': newargs,

- Documentation and metadata improvements.

merit-maita · 2023-05-07T07:59:00Z

Hello @rurhrlaub
can you click on the update branch button at the bottom of the page, it needs to be updated with the changes from master

merit-maita · 2023-05-09T10:35:05Z

Hello @rurhrlaub
here's a couple of steps to be done to be able to merge your pr:

click on the update branch button at the bottom of the page to sync with master.
Add RN (the note i suggested: Documentation and metadata improvements.) and about the docker image being updated.
handle the failing checks of the pr, im available in slack or email (mmaayta@paloaltonetworks) for any question.

Added comment field

xsoar-bot · 2023-05-09T13:55:15Z

Contribution Pack Resubmitted

Contributor: @rurhrlaub

Notes

Updated docker image and re-validated

merit-maita · 2023-05-18T13:57:46Z

@rurhrlaub can you please refer to my comment mentioned above to go ahead with this contribution

…4' into rurhrlaub-contrib-ContentTesting-4

updated rn with doc and metadata

rurhrlaub · 2023-05-18T14:07:07Z

updated the RN again

…4' into rurhrlaub-contrib-ContentTesting-4

rurhrlaub

reviewed

rurhrlaub

reviewed

) * [Marketplace Contribution] Content Testing - Content Pack Update (#26088) * "contribution update to pack "Content Testing"" * pack resubmitted * Update UnitTest.yml Added comment field * Update 1_1_2.md updated rn with doc and metadata --------- Co-authored-by: David Uhrlaub <90627446+rurhrlaub@users.noreply.github.com> * updated docker image * updated docker image --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: David Uhrlaub <90627446+rurhrlaub@users.noreply.github.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: merit <meretmaayta@gmail.com>

"contribution update to pack "Content Testing""

0d593b6

content-bot assigned merit-maita Apr 25, 2023

merit-maita reviewed Apr 30, 2023

View reviewed changes

merit-maita added the pending-contributor The PR is pending the response of its creator label Apr 30, 2023

merit-maita reviewed May 2, 2023

View reviewed changes

merit-maita reviewed May 3, 2023

View reviewed changes

merit-maita added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label May 7, 2023

xsoar-bot and others added 2 commits May 9, 2023 13:55

pack resubmitted

b40de09

Update UnitTest.yml

f4cf935

Added comment field

xsoar-bot force-pushed the rurhrlaub-contrib-ContentTesting-4 branch from d9492a1 to f4cf935 Compare May 9, 2023 13:55

merit-maita removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label May 9, 2023

rurhrlaub added 2 commits May 18, 2023 09:00

Merge branch 'contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-…

9263579

…4' into rurhrlaub-contrib-ContentTesting-4

Update 1_1_2.md

517da44

updated rn with doc and metadata

rurhrlaub approved these changes May 18, 2023

View reviewed changes

Merge branch 'contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-…

a2dc9dc

…4' into rurhrlaub-contrib-ContentTesting-4

rurhrlaub reviewed May 18, 2023

View reviewed changes

merit-maita approved these changes May 24, 2023

View reviewed changes

merit-maita merged commit e0073eb into demisto:contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-4 May 24, 2023

xsoar-bot deleted the rurhrlaub-contrib-ContentTesting-4 branch November 23, 2023 16:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Marketplace Contribution] Content Testing - Content Pack Update #26088

[Marketplace Contribution] Content Testing - Content Pack Update #26088

xsoar-bot commented Apr 25, 2023

merit-maita left a comment

merit-maita Apr 30, 2023

rurhrlaub commented May 1, 2023 via email

merit-maita left a comment

merit-maita May 2, 2023

rurhrlaub commented May 2, 2023 via email

merit-maita left a comment

merit-maita May 3, 2023

merit-maita commented May 7, 2023 •

edited

Loading

merit-maita commented May 9, 2023 •

edited

Loading

xsoar-bot commented May 9, 2023

merit-maita commented May 18, 2023

rurhrlaub commented May 18, 2023

rurhrlaub left a comment

rurhrlaub left a comment


		##### UnitTest

		- Change line 93 from 'args':{}, 'args': newargs,

	- Change line 93 from 'args':{}, 'args': newargs,
	- Documentation and metadata improvements.

[Marketplace Contribution] Content Testing - Content Pack Update #26088

[Marketplace Contribution] Content Testing - Content Pack Update #26088

Conversation

xsoar-bot commented Apr 25, 2023

Status

Contributor

Notes

Video Link

merit-maita left a comment

Choose a reason for hiding this comment

merit-maita Apr 30, 2023

Choose a reason for hiding this comment

rurhrlaub commented May 1, 2023 via email

merit-maita left a comment

Choose a reason for hiding this comment

merit-maita May 2, 2023

Choose a reason for hiding this comment

rurhrlaub commented May 2, 2023 via email

merit-maita left a comment

Choose a reason for hiding this comment

merit-maita May 3, 2023

Choose a reason for hiding this comment

merit-maita commented May 7, 2023 • edited Loading

merit-maita commented May 9, 2023 • edited Loading

xsoar-bot commented May 9, 2023

Contribution Pack Resubmitted

Notes

merit-maita commented May 18, 2023

rurhrlaub commented May 18, 2023

rurhrlaub left a comment

Choose a reason for hiding this comment

rurhrlaub left a comment

Choose a reason for hiding this comment

merit-maita commented May 7, 2023 •

edited

Loading

merit-maita commented May 9, 2023 •

edited

Loading