Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neskope bug fix #26713

Merged
merged 34 commits into from
May 30, 2023
Merged

Neskope bug fix #26713

merged 34 commits into from
May 30, 2023

Conversation

Shellyber
Copy link
Contributor

@Shellyber Shellyber commented May 22, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-22801, https://jira-hq.paloaltonetworks.local/browse/XSUP-24530

Description

  • Fixed an issue with the first timestamp that wasn't calculated correctly
  • Added pagination support
  • Added retires to the http_request calls to avoid connection errors

Minimum version of Cortex XSOAR

  • 6.8.0

Does it break backward compatibility?

  • No

@Shellyber
Merge branch 'master' into neskope-bug-fix
1564daf 
# Conflicts:
#	Packs/Netskope/ReleaseNotes/3_0_15.md
@Shellyber Shellyber requested a review from DeanArbel May 22, 2023 14:57
ShahafBenYakir
ShahafBenYakir reviewed May 28, 2023
View reviewed changes
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Outdated Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Outdated Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Outdated Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Outdated Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Outdated Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Outdated Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Outdated Show resolved Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py Outdated Show resolved Hide resolved
@Shellyber Shellyber merged commit 9b6dfd3 into master May 30, 2023
@Shellyber Shellyber deleted the neskope-bug-fix branch May 30, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahafBenYakir ShahafBenYakir ShahafBenYakir approved these changes

@DeanArbel DeanArbel Awaiting requested review from DeanArbel

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shellyber @ShahafBenYakir