[Marketplace Contribution] VMRay Analyzer - Content Pack Update #28872

xsoar-bot · 2023-08-09T16:01:41Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Contributor

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

Added Descriptions to command

Drizzt-IT · 2023-08-11T11:20:24Z

Hello,
I don't know where the last error comes from.
"[2023-08-11 10:25:23,819] [ERROR] Packs/VMRay/ReleaseNotes/1_2_0.md: [RN107] - No release note entry was found for the playbook "File Enrichment - VMRay""

I didn't change anything in aplaybook here. Could you please advice?

Kind regards,
Konrad

CLAassistant · 2023-08-13T12:53:59Z

All committers have signed the CLA.

kgal-pan · 2023-08-13T13:57:14Z

@jthom-vmray @tkorten-vmray - Can you please have a look and see if the commands added are something you're interested in adding to the integration?

kgal-pan · 2023-08-13T15:08:19Z

Hello, I don't know where the last error comes from. "[2023-08-11 10:25:23,819] [ERROR] Packs/VMRay/ReleaseNotes/1_2_0.md: [RN107] - No release note entry was found for the playbook "File Enrichment - VMRay""

I didn't change anything in aplaybook here. Could you please advice?

Looks like the initial commit did include a Playbook.

Please work on increasing code coverage and add unit tests for the new commands. You can see the coverage report in CircleCI artifacts.

tkorten-vmray · 2023-08-14T13:21:59Z

@kgal-pan Thank you for letting us know.
I will forward it internally.

Drizzt-IT · 2023-08-15T08:59:56Z

@kgal-pan Thank you for letting us know. I will forward it internally.

Just for you to know I'm implementing this on a customer request.
Kind regards,
Konrad

Drizzt-IT · 2023-08-18T09:06:16Z

Any update?

mmhw · 2023-08-23T10:52:24Z

Hi @Drizzt-IT,
Once @jthom-vmray @tkorten-vmray confirm they are interested in it, we can start reviewing the PR.
Thanks!

…ntrib/content into pr/28872

kgal-pan · 2023-09-06T09:56:09Z

@kgal-pan Thank you for letting us know. I will forward it internally.

@tkorten-vmray - Any updates on this?

tkorten-vmray · 2023-09-07T07:02:37Z

Hey @kgal-pan,
sorry for the long response time. We clarified some smaller changes with @Drizzt-IT which are now implemented as part of commit 918d7f8.
With these changes made, we are now interested in adding these commands.
@Drizzt-IT thank you for implementing and @kgal-pan, @mmhw thank you for reviewing them

RosenbergYehuda

Hello @Drizzt-IT,

Great job on your work! I noticed that there were some unresolved conflicts, and since they were causing issues with my code review, I took the liberty to resolve them. I hope that's okay with you.

You've done an excellent job overall, and I've added some minor comments. Please review them and make the necessary corrections. Once you're done, please ping me, and I'll take another look.

If you require any assistance or have any questions, don't hesitate to reach out.

RosenbergYehuda · 2023-09-11T16:58:34Z

Packs/VMRay/Integrations/VMRay/VMRay.yml

@@ -1068,9 +1088,16 @@ script:
  - deprecated: true
    description: Retrieves a sample using the sample ID. (Deprecated)
    name: upload_sample
-  dockerimage: demisto/python3:3.10.12.63474
+    arguments: []
+  - arguments: []


Please remove the empty arguments field, unless this is because a new validation i'm not aware of...

Never mind, I think this was done automatically, I will take care of it.

RosenbergYehuda · 2023-09-11T17:22:37Z

Packs/VMRay/Integrations/VMRay/README.md

@@ -43,6 +43,8 @@ After you successfully execute a command, a DBot message appears in the War Room
 - [vmray-get-iocs](#vmray-get-iocs): Get IOCs for a sample
 - [vmray-get-job-by-id](#vmray-get-job-by-id): Get information for a job
 - [vmray-get-summary](#vmray-get-summary): Download Summary JSON v2 for an analysis
+- [vmray-get-license-usage-verdicts](#vmray-get-license-usage-verdicts): Get the used quota of verdicts


When you press the link to the command, you don't see the details of the command as you should.
Please add to the readme all the details of the command, as the rest of them.
You can use the SDK generate-docs command to do it automatic.

unfortunatly the SDK is not available to me, so I need to create everything by hand.

@RosenbergYehuda I've done the documentation as best as I could.

Kind regards,
Konrad

RosenbergYehuda

Hey @Drizzt-IT,

This PR has my approval!

Let's move on to setting up a live demo so we can see your changes in action.

Let me know what time you are available and your time zone, and I will arrange a meeting.
You can also record a demo of all the changes you made if you prefer.

Waiting to hear from you

Yehuda

Drizzt-IT · 2023-09-14T07:24:54Z

Hey @Drizzt-IT,

This PR has my approval!

Let's move on to setting up a live demo so we can see your changes in action.

Let me know what time you are available and your time zone, and I will arrange a meeting. You can also record a demo of all the changes you made if you prefer.

Waiting to hear from you

Yehuda

Pinged you via Slack

RosenbergYehuda · 2023-09-18T09:06:19Z

Hello @tkorten-vmray,

I have approved this pull request, and now we are waiting for a demonstration before it can be merged. As this is a partner pack, we require a representative from our partner to participate in the demo. Could you please provide your available time slots? You can contact me via Slack or email at yrosenberg@paloaltonetworks.com.

RosenbergYehuda · 2023-09-21T21:38:13Z

Hi @Drizzt-IT,
I sent you an invitation for a demo next week. Please let me know if the time is not good for you.

Have a great weekend!

RosenbergYehuda · 2023-09-28T20:39:34Z

Hello @Drizzt-IT,

I wanted to let you know that I will be on vacation next week due to the holidays here in Israel. I will return to work on October 8th.

Please accept my apologies for any delays this may cause.
Looking forward to catching up when I'm back in the office.

Regards,Yehuda

RosenbergYehuda · 2023-09-29T06:26:37Z

My mistake, I typed January instead of October, I am on vacation until the 8th of October.

…zzt-IT-contrib-VMRay

RosenbergYehuda · 2023-10-15T08:19:42Z

Vmray.Demo.of.comands.mp4

RosenbergYehuda · 2023-10-15T08:33:46Z

Hi @tkorten-vmray,

Since we've had difficulty scheduling a live demo, I asked the contributor to record a video walkthrough of their changes. They have uploaded the video.

I've reviewed it and approved the changes. When you have a moment, please watch the video and let me know if you also approve. This contribution has been waiting for a while, so I'd appreciate if you could take a look as soon as possible.

Let me know if you have any other questions!

tkorten-vmray · 2023-10-18T11:03:01Z

Hi @RosenbergYehuda ,
sorry for the late response. We reviewed it internally and it looks good to us.

* [Marketplace Contribution] VMRay Analyzer - Content Pack Update (#28872) * "contribution update to pack "VMRay Analyzer"" * Fixed several issues / added docs * Update VMRay.yml Added Descriptions to command * Changed as requested * fix conflicts * conflict with docker image * Added documentation for commands * fix the readme * fix yml * format * fix validation --------- Co-authored-by: Konrad <15833518+Drizzt-IT@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com> Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com> * add a period * fix RN * Apply suggestions from Shirley Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * flake 8 * docker * add outputs * adding pragma no cover' since the new functions are straightforward and don't need test * moving the no cover to the new functions instead main * flake 8 --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Konrad <15833518+Drizzt-IT@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com> Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com> Co-authored-by: Yehuda Rosenberg <90599084+RosenbergYehuda@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

"contribution update to pack "VMRay Analyzer""

92c7b90

content-bot assigned mmhw and efelmandar Aug 9, 2023

Drizzt-IT added 2 commits August 9, 2023 18:50

Fixed several issues / added docs

9287de1

Update VMRay.yml

bc16518

Added Descriptions to command

mmhw mentioned this pull request Aug 13, 2023

[VMRay] Change files permissions #28924

Merged

3 tasks

Merge branch 'demisto:master' into Drizzt-IT-contrib-VMRay

c468992

mmhw requested review from dansterenson and GuyAfik as code owners August 13, 2023 12:53

mmhw removed request for dansterenson, GuyAfik and efelmandar August 13, 2023 12:54

mmhw unassigned efelmandar Aug 13, 2023

kgal-pan self-assigned this Aug 13, 2023

Drizzt-IT added 2 commits September 1, 2023 10:05

Changed as requested

918d7f8

Merge branch 'Drizzt-IT-contrib-VMRay' of https://github.com/xsoar-co…

6ab2136

…ntrib/content into pr/28872

RotemAmit requested review from RosenbergYehuda and removed request for mmhw September 7, 2023 09:21

RotemAmit assigned RosenbergYehuda and unassigned mmhw Sep 7, 2023

RosenbergYehuda removed request for michalgold, idovandijk, yaakovpraisler and ilaner September 11, 2023 17:51

conflict with docker image

da6400e

RosenbergYehuda reviewed Sep 11, 2023

View reviewed changes

RosenbergYehuda added the pending-contributor The PR is pending the response of its creator label Sep 11, 2023

Drizzt-IT and others added 3 commits September 12, 2023 18:09

Added documentation for commands

0a3e24a

fix the readme

98ea6b6

Merge remote-tracking branch 'origin' into pr/xsoar-bot/28872

bb6b8e0

RosenbergYehuda requested a review from ostolero as a code owner September 13, 2023 13:42

fix yml

76c0566

RosenbergYehuda added the docs-approved label Sep 13, 2023

RosenbergYehuda added 2 commits September 13, 2023 16:56

format

e8a5350

fix validation

486f2db

RosenbergYehuda removed the request for review from ostolero September 13, 2023 14:00

RosenbergYehuda approved these changes Sep 13, 2023

View reviewed changes

RosenbergYehuda added the pending-demo Demo pending label Sep 13, 2023

Merge branch 'contrib/xsoar-contrib_Drizzt-IT-contrib-VMRay' into Dri…

04302a1

…zzt-IT-contrib-VMRay

RosenbergYehuda merged commit 7ca5cc4 into demisto:contrib/xsoar-contrib_Drizzt-IT-contrib-VMRay Oct 18, 2023
9 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Marketplace Contribution] VMRay Analyzer - Content Pack Update #28872

[Marketplace Contribution] VMRay Analyzer - Content Pack Update #28872

xsoar-bot commented Aug 9, 2023

Drizzt-IT commented Aug 11, 2023

CLAassistant commented Aug 13, 2023 •

edited

Loading

kgal-pan commented Aug 13, 2023

kgal-pan commented Aug 13, 2023 •

edited

Loading

tkorten-vmray commented Aug 14, 2023

Drizzt-IT commented Aug 15, 2023

Drizzt-IT commented Aug 18, 2023

mmhw commented Aug 23, 2023

kgal-pan commented Sep 6, 2023

tkorten-vmray commented Sep 7, 2023 •

edited

Loading

RosenbergYehuda left a comment

RosenbergYehuda Sep 11, 2023

RosenbergYehuda Sep 12, 2023

RosenbergYehuda Sep 11, 2023

Drizzt-IT Sep 12, 2023

Drizzt-IT Sep 12, 2023

RosenbergYehuda left a comment

Drizzt-IT commented Sep 14, 2023

RosenbergYehuda commented Sep 18, 2023

RosenbergYehuda commented Sep 21, 2023

RosenbergYehuda commented Sep 28, 2023 •

edited

Loading

RosenbergYehuda commented Sep 29, 2023

RosenbergYehuda commented Oct 15, 2023

RosenbergYehuda commented Oct 15, 2023

tkorten-vmray commented Oct 18, 2023

[Marketplace Contribution] VMRay Analyzer - Content Pack Update #28872

[Marketplace Contribution] VMRay Analyzer - Content Pack Update #28872

Conversation

xsoar-bot commented Aug 9, 2023

Status

Contributor

Video Link

Drizzt-IT commented Aug 11, 2023

CLAassistant commented Aug 13, 2023 • edited Loading

kgal-pan commented Aug 13, 2023

kgal-pan commented Aug 13, 2023 • edited Loading

tkorten-vmray commented Aug 14, 2023

Drizzt-IT commented Aug 15, 2023

Drizzt-IT commented Aug 18, 2023

mmhw commented Aug 23, 2023

kgal-pan commented Sep 6, 2023

tkorten-vmray commented Sep 7, 2023 • edited Loading

RosenbergYehuda left a comment

Choose a reason for hiding this comment

RosenbergYehuda Sep 11, 2023

Choose a reason for hiding this comment

RosenbergYehuda Sep 12, 2023

Choose a reason for hiding this comment

RosenbergYehuda Sep 11, 2023

Choose a reason for hiding this comment

Drizzt-IT Sep 12, 2023

Choose a reason for hiding this comment

Drizzt-IT Sep 12, 2023

Choose a reason for hiding this comment

RosenbergYehuda left a comment

Choose a reason for hiding this comment

Drizzt-IT commented Sep 14, 2023

RosenbergYehuda commented Sep 18, 2023

RosenbergYehuda commented Sep 21, 2023

RosenbergYehuda commented Sep 28, 2023 • edited Loading

RosenbergYehuda commented Sep 29, 2023

RosenbergYehuda commented Oct 15, 2023

RosenbergYehuda commented Oct 15, 2023

tkorten-vmray commented Oct 18, 2023

CLAassistant commented Aug 13, 2023 •

edited

Loading

kgal-pan commented Aug 13, 2023 •

edited

Loading

tkorten-vmray commented Sep 7, 2023 •

edited

Loading

RosenbergYehuda commented Sep 28, 2023 •

edited

Loading