Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PAN-OS to xpanse MP and core #29826

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-5715

Description

Adding PAN-OS content pack to Xpanse Marketplace and to Xpanse Core Packs in preparation for new content.

PAN-OS dependencies shouldn't cause issues:
"dependencies": {
"CommonPlaybooks": {
"mandatory": true,
"display_name": "Common Playbooks"
},
"CommonScripts": {
"mandatory": true,
"display_name": "Common Scripts"
}
},

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Sep 21, 2023
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_Core-EXPANDR-5715 September 21, 2023 15:42
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @RosenbergYehuda will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Sep 21, 2023
@RosenbergYehuda
Copy link
Contributor

Hello @johnnywilkes, great to connect with you again!

I want to mention that due to the holiday season in Israel, our team will be out of the office until next Tuesday the 26th.I have not reviewed this PR yet, but will do so when I'm back.

Thank you again for your contribution, and enjoy your weekend!

@johnnywilkes johnnywilkes mentioned this pull request Sep 27, 2023
3 tasks
Copy link
Contributor

@RosenbergYehuda RosenbergYehuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@RosenbergYehuda RosenbergYehuda merged commit c961e07 into demisto:contrib/PaloAltoNetworks_Core-EXPANDR-5715 Sep 27, 2023
DeanArbel pushed a commit that referenced this pull request Oct 2, 2023
* add PAN-OS to xpanse MP and core (#29826)

* docker

* RN

* docker #2

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>
wolyslager pushed a commit to wolyslager/content that referenced this pull request Oct 2, 2023
* add PAN-OS to xpanse MP and core (demisto#29826)

* docker

* RN

* docker demisto#2

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* add PAN-OS to xpanse MP and core (demisto#29826)

* docker

* RN

* docker #2

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* add PAN-OS to xpanse MP and core (#29826)

* docker

* RN

* docker #2

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants