Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QRadar] Fallback for event columns #30190

Merged
merged 8 commits into from
Oct 22, 2023
Merged

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Oct 16, 2023

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-28972?filter=-1

Description

Added fallback to default event columns in the query to search events.

If the user set an empty field for some reason, we can override it with the default value.

@ilaner ilaner requested a review from tkatzir October 16, 2023 14:18
Copy link
Contributor

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
Approved, with a comment to review the English by @ShirleyDenkberg .

Packs/QRadar/ReleaseNotes/2_4_38.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@tkatzir Doc review completed.

@ilaner
Copy link
Contributor Author

ilaner commented Oct 19, 2023

Needs force merge as there is an issue with polling on XSOAR server master
@tkatzir

@ilaner ilaner added the ForceMerge Forcing the merge of the PR despite the build status label Oct 19, 2023
@tkatzir tkatzir merged commit 90c1870 into master Oct 22, 2023
16 checks passed
@tkatzir tkatzir deleted the qradar_fallback_events_columns branch October 22, 2023 09:36
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants