Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Versa Director] Updade request headers #30666

Merged

Conversation

samuelFain
Copy link
Contributor

@samuelFain samuelFain commented Nov 5, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-29836

Description

Updated the HTTP request headers to explicitly accept the 'application/json' response format instead of relying on the default behavior of accepting any response format.

@samuelFain samuelFain self-assigned this Nov 6, 2023
@samuelFain samuelFain marked this pull request as ready for review November 6, 2023 15:59
@samuelFain samuelFain requested a review from JasBeilin November 6, 2023 16:09
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, please check my comments before merging.

@samuelFain samuelFain merged commit 287f674 into master Nov 8, 2023
@samuelFain samuelFain deleted the bugfix/XSUP-29836/versa-director-updade-request-headers branch November 8, 2023 20:58
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Update request headers

* ruff updates and improvements

* Update docker image

* Update release notes

* Update headers for UTs

* Update docker image

* Fix warning in input_data.py

* Update Packs/VersaDirector/Integrations/VersaDirector/VersaDirector.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Explicitly added xml headers in requested commands

* Updated UT

---------

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants