SetGridField fixes #31318
Merged
SetGridField fixes #31318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into XSUP-30932/SetGridField
GuyAfik
reviewed
Dec 10, 2023
| @@ -362,24 +369,27 @@ def main(): # pragma: no cover | |||
| keys_from_nested=argToList(args.get('keys_from_nested')) | |||
| ) | |||
| # Execute automation 'setIncident` which change the Context data in the incident | |||
| res = demisto.executeCommand("setIncident", { | |||
| res_set = demisto.executeCommand("setIncident", { | |||
There was a problem hiding this comment.
The res was overwritten by the line:
res = demisto.executeCommand("getIncidents", {"id": demisto.incident().get("id")})
and I would like to save it so I can raise an error if necessary
…into XSUP-30932/SetGridField
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
…into XSUP-30932/SetGridField
ilaner
reviewed
Dec 11, 2023
| custom_fields = data[0].get("CustomFields") if data and data[0].get("CustomFields") else {} | ||
| if (not is_playground) and table and grid_id not in custom_fields: | ||
| raise ValueError(get_error_message(grid_id)) | ||
| if is_error(res_set): |
There was a problem hiding this comment.
let's add is_error to the getIncidents command as well in line 392
ilaner
approved these changes
Dec 11, 2023
sharonfi99
pushed a commit
that referenced
this pull request
Dec 12, 2023
* SetGridField fixes * update docker * add support for incident_id * do only needed change * revert yml * docker image * revert ruff changes * revert ruff changes * fixes * fixes * fixes * RN conflicts * Update SetGridField.py * add tests * fix test * add tests * Update SetGridField_test.py * fixes CR * fix CR review,update docker * Bump pack from version CommonScripts to 1.12.57. * fix CR review * fix CR review --------- Co-authored-by: Content Bot <bot@demisto.com>
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
* SetGridField fixes * update docker * add support for incident_id * do only needed change * revert yml * docker image * revert ruff changes * revert ruff changes * fixes * fixes * fixes * RN conflicts * Update SetGridField.py * add tests * fix test * add tests * Update SetGridField_test.py * fixes CR * fix CR review,update docker * Bump pack from version CommonScripts to 1.12.57. * fix CR review * fix CR review --------- Co-authored-by: Content Bot <bot@demisto.com>
sapirshuker
added a commit
that referenced
this pull request
Dec 21, 2023
* SetGridField fixes * update docker * add support for incident_id * do only needed change * revert yml * docker image * revert ruff changes * revert ruff changes * fixes * fixes * fixes * RN conflicts * Update SetGridField.py * add tests * fix test * add tests * Update SetGridField_test.py * fixes CR * fix CR review,update docker * Bump pack from version CommonScripts to 1.12.57. * fix CR review * fix CR review --------- Co-authored-by: Content Bot <bot@demisto.com>
maimorag
pushed a commit
that referenced
this pull request
Dec 31, 2023
* SetGridField fixes * update docker * add support for incident_id * do only needed change * revert yml * docker image * revert ruff changes * revert ruff changes * fixes * fixes * fixes * RN conflicts * Update SetGridField.py * add tests * fix test * add tests * Update SetGridField_test.py * fixes CR * fix CR review,update docker * Bump pack from version CommonScripts to 1.12.57. * fix CR review * fix CR review --------- Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-30932
https://jira-dc.paloaltonetworks.com/browse/XSUP-31038
https://jira-dc.paloaltonetworks.com/browse/XSUP-30050
Description
Fix an issue that the script to raise an uninformative error when trying to run SetGridField from the playground.
Must have