Feed Elastic: fetch in batches #31377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -291,3 +297,14 @@ def test_extract_api_from_username_password_username_api_key(): | |||
| import FeedElasticsearch as esf | |||
| username = esf.API_KEY_PREFIX + 'api_id' | |||
| assert esf.extract_api_from_username_password(username, 'api_key') == ('api_id', 'api_key') | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
check recommit error
Packs/FeedElasticsearch/Integrations/FeedElasticsearch/FeedElasticsearch.py
Show resolved
Hide resolved
| @@ -100,7 +105,7 @@ configuration: | |||
| name: feedExpirationInterval | |||
| type: 1 | |||
| required: false | |||
| - defaultvalue: '240' | |||
| - defaultvalue: '10' | |||
There was a problem hiding this comment.
what was this changed?
There was a problem hiding this comment.
This is the fetch interval.
SInce in the previous version it fetched all the indicators in one batch, it was making sense to set the feed interval for 4 hours.
In the current version it will fetch in batches, so it doesn't really make sense to wait 4 hours until the next batch.
yuvalbenshalom
approved these changes
Dec 13, 2023
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
maimorag
pushed a commit
that referenced
this pull request
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://jira-dc.paloaltonetworks.com/browse/CIAC-8889
This will fetch indictaors in batches