Slack bb fixes #31393
Merged
Slack bb fixes #31393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalbenshalom
requested changes
Dec 11, 2023
Packs/Slack/ReleaseNotes/3_2_8.json
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "breakingChanges": true, | |||
| "breakingChangesNotes": "SlackBlockBuilder no longer relies on the XSOAR API in order to update an incident's context. As such, playbooks which currently use the SlackBlockBuilder script should be modified as described in the documentation." | |||
There was a problem hiding this comment.
I think we should name the location of the relevant documentation. like "readme, sub section {name}"
yuvalbenshalom
requested changes
Dec 14, 2023
Packs/Slack/Playbooks/playbook-Slack_BlockBuilderExample_README.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "breakingChanges": true, | |||
| "breakingChangesNotes": "- SlackBlockBuilder no longer relies on the XSOAR API in order to update an incident's context. As such, playbooks which currently use the SlackBlockBuilder script should be modified as described in the documentation.\n- Additional information regarding the change and migrating to pack version 3.3.0 can be found [here.](https://xsoar.pan.dev/docs/reference/scripts/slack-block-builder#troubleshooting)" | |||
There was a problem hiding this comment.
need to test that this link is working on the popup before merge.
Packs/Slack/Scripts/GetSlackBlockBuilderResponse/GetSlackBlockBuilderResponse.py
Outdated
Show resolved
Hide resolved
yuvalbenshalom
approved these changes
Dec 17, 2023
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
maimorag
pushed a commit
that referenced
this pull request
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-31182
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-31179
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-28661
Description
SBB was using the internal API to post updates to an incident's context. We've changed the implementation to remove the need to the internal API call.
Must have