Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAN-OS Policy Optimizer] Add pagination support to pan-os-po-get-rules #31402

Merged
merged 16 commits into from
Dec 17, 2023

Conversation

MichaelYochpaz
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Add pagination support to the pan-os-po-get-rules command (which previously fetched only up to 200 items), using 2 new parameters - limit and page_size.

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MichaelYochpaz MichaelYochpaz merged commit f2087ca into master Dec 17, 2023
@MichaelYochpaz MichaelYochpaz deleted the pan-os-po-increase-rules-limit branch December 17, 2023 08:24
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
…les` (#31402)

* Improve readability

* Add pagination to `policy_optimizer_get_rules`

* Readable output improvements

* Fix `argToBoolean` resulting in error if the optional `exclude` parameter is missing

* Add pagination parameters

* ruff

* Update README

* Add release-notes and bump version

* Fix mypy issues

* Minor release-notes fix

* Fix unit-tests

* Add `page` parameter

* Add pagination unit-test

* Bump Docker version
maimorag pushed a commit that referenced this pull request Dec 31, 2023
…les` (#31402)

* Improve readability

* Add pagination to `policy_optimizer_get_rules`

* Readable output improvements

* Fix `argToBoolean` resulting in error if the optional `exclude` parameter is missing

* Add pagination parameters

* ruff

* Update README

* Add release-notes and bump version

* Fix mypy issues

* Minor release-notes fix

* Fix unit-tests

* Add `page` parameter

* Add pagination unit-test

* Bump Docker version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants