Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pack: HashiCorp Terraform #31518

Merged
merged 19 commits into from
Dec 19, 2023
Merged

Conversation

ilappe
Copy link
Contributor

@ilappe ilappe commented Dec 17, 2023

Related Issues

fixes:https://jira-dc.paloaltonetworks.com/browse/CIAC-3891

Description

new pack with one integration

Must have

  • Tests
  • Documentation

@ilappe ilappe self-assigned this Dec 17, 2023
@ilappe ilappe mentioned this pull request Dec 17, 2023
2 tasks
@ilappe ilappe marked this pull request as ready for review December 17, 2023 12:17
@ilappe ilappe requested a review from michal-dagan as a code owner December 17, 2023 12:17
@ShirleyDenkberg
Copy link
Contributor

@ilappe Please regenerate the readme.
@DeanArbel @michal-dagan Doc review completed.

ilappe and others added 5 commits December 18, 2023 09:42
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, please make sure to run ruff on the python file (precommit hook)

@ilappe ilappe merged commit 97df1ff into master Dec 19, 2023
@ilappe ilappe deleted the ilappe_ciac-3891_hashicorp_integration branch December 19, 2023 21:10
content-bot pushed a commit that referenced this pull request Dec 20, 2023
* initial work

* update test

* update

* update after demo

* finish

* fix test

* update conf.json with test details

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* apply CR changes

* apply CR changes

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* initial work

* update test

* update

* update after demo

* finish

* fix test

* update conf.json with test details

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* apply CR changes

* apply CR changes

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants