Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incident occurred time #31522

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@wolyslager

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Updating the "occurred time" field for incidents created. Previously this was just using the fetch time for the incident - but now we have incident details available (added in a previous pr) so we can accurately display the correct occurred time.

Must have

  • Tests
  • Documentation

* updating occurred time for incidents

* release notes

* validation fixes

* nit

* fix formatting

* update RN

---------

Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Partner Contribution Form Filled Whether contribution form filled or not. pending-contributor The PR is pending the response of its creator Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Partner-Approved TIM Review labels Dec 17, 2023
@content-bot content-bot requested a review from adi88d December 17, 2023 13:35
@adi88d adi88d merged commit bc69d12 into master Dec 17, 2023
@adi88d adi88d deleted the contrib/wolyslager_update-incident-occurred-time branch December 17, 2023 15:57
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Update incident occurred time (#31404)

* updating occurred time for incidents

* release notes

* validation fixes

* nit

* fix formatting

* update RN

---------

Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>

* add new line

* update RN

* remove whitespace from blank line

---------

Co-authored-by: William Olyslager <wolyslager@abnormalsecurity.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* Update incident occurred time (#31404)

* updating occurred time for incidents

* release notes

* validation fixes

* nit

* fix formatting

* update RN

---------

Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>

* add new line

* update RN

* remove whitespace from blank line

---------

Co-authored-by: William Olyslager <wolyslager@abnormalsecurity.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator TIM Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants