Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit] remove __init__folders, fix script_runner and add commit mode #31579

Merged
merged 3 commits into from
Dec 20, 2023
Merged

[pre-commit] remove __init__folders, fix script_runner and add commit mode #31579

merged 3 commits into from
Dec 20, 2023

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Dec 20, 2023 •
edited
Loading

  • fix issue with script runner when the script errors resulted error code 0 (not pytest failures, but failures executing the script)
  • Remove init folders from content (if we want to add __init__, we need to add in all of them, since those packages has priority over others.
  • Add commit mode to the template

@ilaner ilaner requested a review from dorschw as a code owner December 20, 2023 09:49
@ilaner ilaner requested a review from JudahSchwartz December 20, 2023 09:49
@ilaner
Copy link
Contributor Author

ilaner commented Dec 20, 2023

this will need a force merge because we delete__init__.py files and this is not allowed in our validate:
image

@ilaner ilaner added the ForceMerge Forcing the merge of the PR despite the build status label Dec 20, 2023
@kobymeir kobymeir merged commit 0315a73 into master Dec 20, 2023
@kobymeir kobymeir deleted the add_init_to_test_data branch December 20, 2023 10:00
content-bot pushed a commit that referenced this pull request Dec 20, 2023
@ilaner
[pre-commit] remove __init__folders, fix script_runner and add commit…
669d85f 
… mode (#31579)

[pre-commit] remove __init__folders, fix script_runner and add commit mode #31579
maimorag pushed a commit that referenced this pull request Dec 31, 2023
@ilaner @maimorag
[pre-commit] remove __init__folders, fix script_runner and add commit…
2720f84 
… mode (#31579)

[pre-commit] remove __init__folders, fix script_runner and add commit mode #31579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobymeir kobymeir kobymeir approved these changes

@dorschw dorschw Awaiting requested review from dorschw

@JudahSchwartz JudahSchwartz Awaiting requested review from JudahSchwartz

Assignees
No one assigned
Labels
ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilaner @kobymeir