Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/[XSUP-33100]/GitHub/Payload too large #33045

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented Feb 21, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

We ran into a problem that when we sent a get request with body='"null"' we got a 413 Payload Too Large error and that's probably Because the header Content-Length was equal to 4 (while it should be 0 because it's a get request) I added a check that the body will not be sent if it is None

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler self-assigned this Feb 21, 2024
@MosheEichler MosheEichler changed the title CR change user agent and remove data in get request Fix/[XSUP-33100](https://jira-dc.paloaltonetworks.com/browse/XSUP-33100)/GitHub/Payload too large Feb 21, 2024
@MosheEichler MosheEichler changed the title Fix/[XSUP-33100](https://jira-dc.paloaltonetworks.com/browse/XSUP-33100)/GitHub/Payload too large Fix/[XSUP-33100]/GitHub/Payload too large Feb 21, 2024
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/GitHub/Integrations/GitHub
   GitHub.py103957045%57, 59–63, 73, 82–89, 91–92, 122–123, 125–129, 131–133, 135–138, 140, 142–143, 145–146, 149, 151, 153–154, 160, 164–165, 170–172, 174–175, 177–178, 180–181, 183–184, 186, 214, 231, 237, 274, 288–289, 294–295, 300–301, 303–304, 311, 320, 371, 388, 400, 410, 429–430, 510, 566, 572, 574, 588, 595, 602–603, 607–609, 613–621, 623–624, 627–628, 662–666, 668, 677–679, 683–684, 687–688, 692–694, 698–702, 704–707, 709–710, 713–714, 718–720, 724–726, 728–729, 732–733, 737–738, 740–742, 746–750, 752–753, 756–757, 761–763, 767–774, 778–780, 784–786, 788–789, 792–793, 797–799, 803–805, 807, 818, 822, 825–826, 830–831, 833–835, 839–843, 845, 856, 860, 863–864, 868–870, 874–876, 878–879, 883, 886, 888, 901–904, 906–907, 910–911, 915–917, 921–924, 926–927, 930–931, 948–950, 954–957, 959–961, 965, 968, 970, 974–976, 997–1004, 1006, 1014, 1017–1018, 1052–1053, 1057–1058, 1062–1067, 1071–1072, 1076–1080, 1084, 1086–1093, 1097–1104, 1107, 1112–1113, 1116–1117, 1119, 1123, 1129, 1132, 1136–1137, 1139–1140, 1144, 1147, 1151–1154, 1158, 1164, 1167, 1171–1172, 1174–1175, 1179–1180, 1183–1184, 1186, 1190, 1195–1201, 1203, 1207, 1211–1213, 1215–1217, 1220–1221, 1223, 1256, 1265, 1283, 1307–1310, 1312–1313, 1344, 1360, 1365–1366, 1368, 1422–1424, 1433, 1439, 1442–1446, 1448, 1456, 1458, 1461, 1475–1477, 1479, 1492–1493, 1495, 1509–1510, 1512, 1533, 1548–1550, 1552, 1554–1555, 1557–1560, 1563–1564, 1571, 1574, 1577, 1583, 1585–1590, 1592–1594, 1596, 1601, 1603–1606, 1608, 1613–1614, 1616, 1624, 1628–1632, 1634–1635, 1637, 1639–1641, 1643, 1645–1647, 1656–1658, 1662–1668, 1670–1675, 1677, 1679, 1684–1686, 1688, 1696, 1698–1701, 1703, 1705, 1707, 1714–1718, 1720, 1722, 1725–1735, 1737, 1749, 1755, 1759–1761, 1768–1769, 1771, 1790, 1792–1793, 1801–1805, 1810–1812, 1814–1815, 1817–1819, 1821, 1823, 1827–1831, 1836–1838, 1840–1841, 1843–1846, 1871–1878, 1887, 1913, 1925, 1931–1934, 1946–1948, 1952–1956, 1958–1959, 1962–1963, 1967–1971, 1975–1977, 1980, 1982, 1984–1985, 2060, 2094, 2234–2237, 2239–2240, 2256–2257, 2262
TOTAL103957045% 

Tests Skipped Failures Errors Time
24 0 💤 0 ❌ 0 🔥 1.585s ⏱️

@ShirleyDenkberg
Copy link
Contributor

@thefrieddan1 Doc review completed.

@MosheEichler MosheEichler merged commit ecfbdda into master Feb 28, 2024
23 checks passed
@MosheEichler MosheEichler deleted the fix-payload-to-large-in-github branch February 28, 2024 10:39
rundssoar pushed a commit to rundssoar/content that referenced this pull request Feb 28, 2024
* CR change user agent and remove data in get request

* add ut

* add ut

* revert

* RN

* revert

* RN
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* CR change user agent and remove data in get request

* add ut

* add ut

* revert

* RN

* revert

* RN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants