-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/[XSUP-33100]/GitHub/Payload too large #33045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thefrieddan1 Doc review completed. |
thefrieddan1
approved these changes
Feb 28, 2024
rundssoar
pushed a commit
to rundssoar/content
that referenced
this pull request
Feb 28, 2024
* CR change user agent and remove data in get request * add ut * add ut * revert * RN * revert * RN
maimorag
pushed a commit
that referenced
this pull request
Feb 28, 2024
* CR change user agent and remove data in get request * add ut * add ut * revert * RN * revert * RN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
We ran into a problem that when we sent a get request with
body='"null"'
we got a413 Payload Too Large
error and that's probably Because the headerContent-Length
was equal to4
(while it should be 0 because it's a get request) I added a check that the body will not be sent if it isNone
Must have