From 27de170798f1162b28cb3f4172b4c52676c1a1d8 Mon Sep 17 00:00:00 2001 From: karinafishman Date: Mon, 8 Jul 2024 10:44:07 +0300 Subject: [PATCH 1/7] added the relevant script to the metrics --- .../Dashboards/XSOAR_Automation_Insights.json | 5 ++++- Packs/CommonDashboards/ReleaseNotes/1_7_3.md | 4 ++++ .../Scripts/AdoptionMetrics/AdoptionMetrics.py | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Packs/CommonDashboards/Dashboards/XSOAR_Automation_Insights.json b/Packs/CommonDashboards/Dashboards/XSOAR_Automation_Insights.json index e8120bf8d8ff..bc5a5c28f0b6 100644 --- a/Packs/CommonDashboards/Dashboards/XSOAR_Automation_Insights.json +++ b/Packs/CommonDashboards/Dashboards/XSOAR_Automation_Insights.json @@ -834,6 +834,9 @@ }, "type": "above" }, + "keys": [ + "sum|droppedCount" + ], "valuesFormat": "abbreviated" }, "category": "" @@ -972,7 +975,7 @@ "prevName": "Use Case Adoption Coverage", "dataType": "scripts", "widgetType": "text", - "query": "UseCaseAdoptionMetrics", + "query": "AdoptionMetrics", "isPredefined": false, "dateRange": { "fromDate": "0001-01-01T00:00:00Z", diff --git a/Packs/CommonDashboards/ReleaseNotes/1_7_3.md b/Packs/CommonDashboards/ReleaseNotes/1_7_3.md index 5ee4f4dc385f..8e4fa4223fcf 100644 --- a/Packs/CommonDashboards/ReleaseNotes/1_7_3.md +++ b/Packs/CommonDashboards/ReleaseNotes/1_7_3.md @@ -4,3 +4,7 @@ ##### My Threat Landscape - Updated the indicators query in the widgets to improve performance. + +##### UseCaseAdoptionMetrics + +- Fix for Adoption Coverage metrics, added the relevant script. diff --git a/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py b/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py index 4de25ebdffdf..819f603a7036 100644 --- a/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py +++ b/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py @@ -108,7 +108,7 @@ def main(): t.append({'Use Case Adoption & Coverage': use_case, 'Status': '❌'}) table = tableToMarkdown(name='Use Case Coverage', t=t, headers=headers) - return table + return_results(table) ''' ENTRY POINT ''' From b67c1483c1b6df8a64fb9bf5ce2154d764adbea0 Mon Sep 17 00:00:00 2001 From: karinafishman Date: Mon, 8 Jul 2024 10:57:45 +0300 Subject: [PATCH 2/7] added rn --- Packs/CommonDashboards/ReleaseNotes/1_7_4.md | 12 ++++++++++++ Packs/CommonDashboards/pack_metadata.json | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 Packs/CommonDashboards/ReleaseNotes/1_7_4.md diff --git a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md new file mode 100644 index 000000000000..d90a3b6b7606 --- /dev/null +++ b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md @@ -0,0 +1,12 @@ + +#### Dashboards + +##### XSOAR Automation Insights + +- %%UPDATE_RN%% + +#### Scripts + +##### AdoptionMetrics + +- %%UPDATE_RN%% diff --git a/Packs/CommonDashboards/pack_metadata.json b/Packs/CommonDashboards/pack_metadata.json index 3561716d2307..843a63ba6c55 100644 --- a/Packs/CommonDashboards/pack_metadata.json +++ b/Packs/CommonDashboards/pack_metadata.json @@ -2,7 +2,7 @@ "name": "Common Dashboards", "description": "Frequently used dashboards pack.", "support": "xsoar", - "currentVersion": "1.7.3", + "currentVersion": "1.7.4", "author": "Cortex XSOAR", "url": "https://www.paloaltonetworks.com/cortex", "email": "", From 422fe5a55d6dfd566d791196b9f824498a9faaef Mon Sep 17 00:00:00 2001 From: karinafishman Date: Mon, 8 Jul 2024 10:59:19 +0300 Subject: [PATCH 3/7] fix --- Packs/CommonDashboards/ReleaseNotes/1_7_3.md | 4 ---- Packs/CommonDashboards/ReleaseNotes/1_7_4.md | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Packs/CommonDashboards/ReleaseNotes/1_7_3.md b/Packs/CommonDashboards/ReleaseNotes/1_7_3.md index 8e4fa4223fcf..5ee4f4dc385f 100644 --- a/Packs/CommonDashboards/ReleaseNotes/1_7_3.md +++ b/Packs/CommonDashboards/ReleaseNotes/1_7_3.md @@ -4,7 +4,3 @@ ##### My Threat Landscape - Updated the indicators query in the widgets to improve performance. - -##### UseCaseAdoptionMetrics - -- Fix for Adoption Coverage metrics, added the relevant script. diff --git a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md index d90a3b6b7606..ff30291bb4ae 100644 --- a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md +++ b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md @@ -3,10 +3,10 @@ ##### XSOAR Automation Insights -- %%UPDATE_RN%% +- Added the relevant script to the metrics. #### Scripts ##### AdoptionMetrics -- %%UPDATE_RN%% +- Fixed the return argument in the script. From 280c3d535940cc67dd985f1761c0c6601b8844d1 Mon Sep 17 00:00:00 2001 From: karinafishman Date: Mon, 8 Jul 2024 11:32:50 +0300 Subject: [PATCH 4/7] pre commit --- Packs/CommonDashboards/ReleaseNotes/1_7_4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md index ff30291bb4ae..9023ecb0802a 100644 --- a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md +++ b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md @@ -9,4 +9,4 @@ ##### AdoptionMetrics -- Fixed the return argument in the script. +- Fixed the return argument in the AdoptionMetrics script. From 308f69c52d7a88602e907381a1031a2179635d96 Mon Sep 17 00:00:00 2001 From: Karina Fishman Date: Mon, 8 Jul 2024 12:34:58 +0300 Subject: [PATCH 5/7] fix --- .../CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py | 1 + 1 file changed, 1 insertion(+) diff --git a/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py b/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py index 819f603a7036..e42f9d22564f 100644 --- a/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py +++ b/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py @@ -109,6 +109,7 @@ def main(): table = tableToMarkdown(name='Use Case Coverage', t=t, headers=headers) return_results(table) + return table ''' ENTRY POINT ''' From 45d8ce4874d86bbb06e006eea11d8c10b54ba5c8 Mon Sep 17 00:00:00 2001 From: Karina Fishman Date: Tue, 9 Jul 2024 18:28:59 +0300 Subject: [PATCH 6/7] updated RN after revert --- Packs/CommonDashboards/ReleaseNotes/1_7_4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md index 9023ecb0802a..ee350fffe7da 100644 --- a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md +++ b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md @@ -3,7 +3,7 @@ ##### XSOAR Automation Insights -- Added the relevant script to the metrics. +- Updated the "Adoption Metrics" widgets' script. #### Scripts From be79aecfa63f5dca7865e0f6a977ad6a1435d0f0 Mon Sep 17 00:00:00 2001 From: Karina Fishman <147307864+karinafishman@users.noreply.github.com> Date: Tue, 9 Jul 2024 18:31:12 +0300 Subject: [PATCH 7/7] Update Packs/CommonDashboards/ReleaseNotes/1_7_4.md Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com> --- Packs/CommonDashboards/ReleaseNotes/1_7_4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md index ee350fffe7da..cdb139608d4f 100644 --- a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md +++ b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md @@ -9,4 +9,4 @@ ##### AdoptionMetrics -- Fixed the return argument in the AdoptionMetrics script. +- Fixed the return argument.