Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed to datetime UTC #35363

Closed
wants to merge 8 commits into from
Closed

Conversation

MosheEichler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed ruff failure UP017 Use datetime.UTC alias
https://docs.astral.sh/ruff/rules/datetime-timezone-utc/

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler self-assigned this Jul 10, 2024
@MosheEichler MosheEichler requested a review from samuelFain July 10, 2024 20:51
Copy link

Your contributed CofenseTriage pack has been modified on files:

Packs/CofenseTriage/Integrations/CofenseTriagev2/CofenseTriagev2.py
Please review the changes here

Copy link

github-actions bot commented Jul 10, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CofenseTriage/Integrations/CofenseTriagev2
   CofenseTriagev2.py3587180%51–53, 56, 93, 172, 339, 376, 392, 429, 447–449, 454–456, 531, 543–545, 549–551, 568–569, 604, 616, 653, 656, 720–721, 723, 725–728, 730–731, 734, 738–740, 742, 744, 746, 749, 762, 787–788, 790, 792–793, 795–796, 798–799, 801–802, 804–805, 807–808, 810–811, 813–814, 816–817, 819–821
TOTAL3587180% 

Tests Skipped Failures Errors Time
46 0 💤 0 ❌ 0 🔥 2.385s ⏱️

@MosheEichler
Copy link
Contributor Author

@samuelFain related to this pr


##### Cofense Triage v2

Documentation and metadata improvements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Documentation and metadata improvements.
- Documentation and metadata improvements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Why not add a line about the datetime.UTC change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants