Trend micro vision one #37276
Trend micro vision one #37276
Conversation
…oming mapper, yml and README.md.
…ript. Updated test data and formatted YML.
…rendMicroVisionOneV3.yml Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
…rendMicroVisionOneV3.yml Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
…rendMicroVisionOneV3.yml Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/shaqnawe_TrendMicroVisionOne-1
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @amshamah419 will know the proposed changes are ready to be reviewed. |
content-bot
added
Partner-Approved
Contribution Form Filled
There was a problem hiding this comment.
Thanks for your contribution @shaqnawe! Just a few comments, but otherwise it looks pretty straightforward. Can you add release notes to this PR? You can do so by running demisto-sdk update-release-notes -i Packs/TrendMicroVisionOne. This will do two things: Bump the pack version, and also generate a release note file. In the file, just write down what the changes are (we can help with the wording).
| @@ -1372,7 +1431,7 @@ script: | |||
| type: string | |||
| description: Displays a list of Observed Attack Techniques events that match the specified criteria. | |||
| name: trendmicro-visionone-get-observed-attack-techniques | |||
| dockerimage: demisto/pytmv1:0.8.7.104820 | |||
| dockerimage: devtesting/pytmv1:0.9.0.1730248273 | |||
There was a problem hiding this comment.
Was there a change to the docker image which requires this change?
There was a problem hiding this comment.
@amshamah419 FYI, this this is matching dockerfiles PR: demisto/dockerfiles#34200.
There was a problem hiding this comment.
I have closed the aforementioned dockerfiles PR and created a new one demisto/dockerfiles#34362.
Once the dockerfiles PR is merged and the new image is available, the docker image tag will have to be updated accordingly.
There was a problem hiding this comment.
Hi @shaqnawe I ran the testing on gitlab and it looks like the docker image is good to go. I approved and merged the PR so we can get a new docker tag for you. I'll edit this message when it's created.
As promised:
demisto/pytmv1:0.9.1.117354
Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3_test.py
Outdated
Show resolved
Hide resolved
|
Once we get the dockerfiles pr merged, the pre-commit should run. Otherwise I think the PR is in good shape and good to merge. |
| @@ -1372,7 +1431,7 @@ script: | |||
| type: string | |||
| description: Displays a list of Observed Attack Techniques events that match the specified criteria. | |||
| name: trendmicro-visionone-get-observed-attack-techniques | |||
| dockerimage: demisto/pytmv1:0.8.7.104820 | |||
| dockerimage: devtesting/pytmv1:0.9.1.1732053127 | |||
There was a problem hiding this comment.
| dockerimage: devtesting/pytmv1:0.9.1.1732053127 | |
| dockerimage: demisto/pytmv1:0.9.1.117354 |
amshamah419
merged commit f5ef135
into
demisto:contrib/shaqnawe_TrendMicroVisionOne-1
|
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
| - contextPath: VisionOne.Endpoint_Info.componentUpdatePolicy | ||
| description: The update policy for the module/pattern of the agent installed on the endpoint. | ||
| type: string | ||
| - contextPath: VisionOne.Endpoint_Info.componentUpdateStatus | ||
| description: The status of the module/pattern updates of the agent installed on the endpoint. | ||
| type: string | ||
| - contextPath: VisionOne.Endpoint_Info.componentVersion | ||
| description: The agent component version. | ||
| type: string | ||
| - contextPath: VisionOne.Endpoint_Info.policyName | ||
| description: The name of a policy for an event. | ||
| type: string | ||
| - contextPath: VisionOne.Endpoint_Info.protectionManager | ||
| description: The name of your protection manager. | ||
| type: string |
There was a problem hiding this comment.
Hey @shaqnawe just one last thing I missed. Is this meant to be in camelcase, or is it supposed to be in snake case?
There was a problem hiding this comment.
Hey @amshamah419 It's supposed to be snake case, can I still make the change?
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Added outputs to get endpoint info and get alert details.
Must have