Skip to content

Conversation

@YVbakker
Copy link
Contributor

@YVbakker YVbakker commented Sep 5, 2024

This tiny PR will slightly improve performance, by generating the regexes compile-time as per .NET regular expression source generators

closes #5

@eNeRGy164
Copy link
Member

Did you benchmark it? Or do you expect it to be more performant?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10727829544

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 38.591%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DendroDocs.Shared/Descriptions/DocumentationCommentsDescription.cs 0 2 0.0%
Totals Coverage Status
Change from base Build 10724213072: 0.1%
Covered Lines: 189
Relevant Lines: 457

💛 - Coveralls

@eNeRGy164 eNeRGy164 merged commit e9d55e1 into dendrodocs:main Sep 13, 2024
@eNeRGy164 eNeRGy164 added the code quality Improvements to code style, structure, or coverage without adding new features or fixing bugs. label Sep 14, 2024
@YVbakker YVbakker deleted the feature/5-generatedregex-attribute branch September 25, 2024 19:21
@YVbakker
Copy link
Contributor Author

YVbakker commented Sep 25, 2024

Did you benchmark it? Or do you expect it to be more performant?

Sorry I didn't reply anymore, I kind of just expected it to be more performant after reading about it on the Microsoft docs page. However, in the future benchmarking these things isn't a bad idea and definitely something I'd want to experiment with! Happy to see it merged now anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improvements to code style, structure, or coverage without adding new features or fixing bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use GeneratedRegex attribute instead of Regex ctor

3 participants