Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical derivatives are confusing... #31

Merged
merged 8 commits into from
Sep 10, 2024
Merged

Numerical derivatives are confusing... #31

merged 8 commits into from
Sep 10, 2024

Conversation

denehoffman
Copy link
Owner

Fixed a lot of small things that were probably causing incorrect Function::hessian calls.

  • Finite difference step size is now strictly positive (wasn't before but the signs cancelled out) and equal to eps * (1 + |x|)
  • Bounds/lack thereof were improperly mixed around in the various methods' Algorithm::postprocessing calls
  • Hessian was reworked
  • Other quality of life improvements

This should all lead to more-correct parameter uncertainties

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 71.16%. Comparing base (1166f06) to head (4439601).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 58.33% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #31       +/-   ##
==========================================
+ Coverage   0.19%   71.16%   +70.97%     
==========================================
  Files          8        8               
  Lines       1020     1762      +742     
==========================================
+ Hits           2     1254     +1252     
+ Misses      1018      508      -510     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denehoffman denehoffman merged commit 48c323e into main Sep 10, 2024
3 checks passed
@denehoffman denehoffman deleted the hotfixes branch September 10, 2024 21:26
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant