Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dyn_clone to pass Algorithms by reference #40

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

denehoffman
Copy link
Owner

Previously, trying to store an Algorithm in a Box would make it next to impossible to then use it in a Minimizer. This update should fix that and will probably minimally affect performance.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (8a5f682) to head (01a0c77).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files           8        8           
  Lines        1811     1811           
=======================================
  Hits         1270     1270           
  Misses        541      541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denehoffman denehoffman merged commit ee3c9ca into main Oct 21, 2024
6 checks passed
@denehoffman denehoffman deleted the boxed_update branch October 21, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant