Fixed a crash when reflecting on a write-only property.

dennisdoomen · Nov 23, 2024 · d883c99 · d883c99
1 parent b723530
commit d883c99
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 8 deletions.
diff --git a/src/Reflectify/Reflectify.cs b/src/Reflectify/Reflectify.cs
@@ -647,9 +647,8 @@ private void AddNormalProperties(MemberKind kind, PropertyInfo[] allProperties)
 
     private static bool HasVisibility(MemberKind kind, PropertyInfo prop)
     {
-        return (kind.HasFlag(MemberKind.Public) && prop.GetMethod?.IsPublic is true) ||
-               (kind.HasFlag(MemberKind.Internal) &&
-                (prop.GetMethod?.IsAssembly is true || prop.GetMethod?.IsFamilyOrAssembly is true));
+        return (kind.HasFlag(MemberKind.Public) && prop.IsPublic()) ||
+               (kind.HasFlag(MemberKind.Internal) && prop.IsInternal());
     }
 
     private void AddExplicitlyImplementedProperties(MemberKind kind, PropertyInfo[] allProperties)
@@ -678,12 +677,12 @@ private void AddInterfaceProperties(Type typeToReflect, MemberKind kind, Binding
         {
             var interfaces = typeToReflect.GetInterfaces();
 
-            foreach (var iface in interfaces)
+            foreach (var interfaceType in interfaces)
             {
-                foreach (var prop in iface.GetProperties(flags))
+                foreach (var prop in interfaceType.GetProperties(flags))
                 {
                     if (!collectedPropertyNames.Contains(prop.Name) &&
-                        (!prop.GetMethod.IsAbstract || typeToReflect.IsInterface))
+                        (!prop.IsAbstract() || typeToReflect.IsInterface))
                     {
                         selectedProperties.Add(prop);
                         collectedPropertyNames.Add(prop.Name);

diff --git a/tests/Reflectify.Specs/TypeMemberExtensionsSpecs.cs b/tests/Reflectify.Specs/TypeMemberExtensionsSpecs.cs
@@ -141,6 +141,19 @@ public void Can_get_internal_properties()
             });
         }
 
+        [Fact]
+        public void Can_get_write_only_properties()
+        {
+            // Act
+            var properties = typeof(ClassImplementingSetterOnlyInterface)
+                .GetProperties(MemberKind.Public | MemberKind.DefaultInterfaceProperties | MemberKind.ExplicitlyImplemented);
+
+            // Assert
+            properties.Should().BeEquivalentTo([
+                new { Name = "WriteOnlyProperty", PropertyType = typeof(string) }
+            ]);
+        }
+
         [Fact]
         public void Will_ignore_indexers()
         {
@@ -702,7 +715,6 @@ public void Can_find_the_explicit_convertor_for_a_specific_source_and_target_typ
             var convertor = typeof(ClassWithConversionOperators)
                 .FindExplicitConversionOperator(typeof(ClassWithConversionOperators), typeof(int));
 
-
             // Assert
             convertor.Should().NotBeNull();
             convertor.ReturnType.Should().Be<int>();
@@ -726,7 +738,6 @@ public void Can_find_the_implicit_convertor_for_a_specific_source_and_target_typ
             var convertor = typeof(ClassWithConversionOperators)
                 .FindImplicitConversionOperator(typeof(ClassWithConversionOperators), typeof(string));
 
-
             // Assert
             convertor.Should().NotBeNull();
             convertor.ReturnType.Should().Be<string>();
@@ -811,6 +822,16 @@ private interface IInterfaceWithSingleProperty
         string ExplicitlyImplementedProperty { get; set; }
     }
 
+    private class ClassImplementingSetterOnlyInterface : IWithSetterOnlyProperty
+    {
+        public string WriteOnlyProperty { private get; set; }
+    }
+
+    private interface IWithSetterOnlyProperty
+    {
+        string WriteOnlyProperty { set; }
+    }
+
     private sealed class ClassWithIndexer
     {
         [UsedImplicitly]