Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto reconnect hangup #431

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Fix auto reconnect hangup #431

merged 3 commits into from
Mar 29, 2024
+50 −4

Conversation

yahiro07
Copy link
Contributor

@yahiro07 yahiro07 commented Mar 24, 2024 •
edited
Loading

This PR will fix the hangup problem in auto-reconnect.

I added a flag in sendCommand options.
The flag inline bypasses the queueing and executes the command immediately.

Hangup problem is avoided by executing the command AUTH and SELECT with inline options.

Please check:

  • The fails (hangs up) if you only add the test code.
  • The test passes if you apply whole changes.

Closes #430

@yahiro07 yahiro07 marked this pull request as ready for review March 24, 2024 16:10
@uki00a uki00a merged commit 48dced2 into denodrivers:master Mar 29, 2024
2 checks passed
@uki00a
Copy link
Member

uki00a commented Mar 29, 2024

LGTM! Thanks for fixing this 👍

@uki00a
Copy link
Member

uki00a commented Mar 29, 2024

v0.32.3 has been released!

@yahiro07
Copy link
Contributor Author

Thank you! I'm glad it's applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uki00a uki00a uki00a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hang up on auto reconnect
2 participants
@yahiro07 @uki00a