Implement SQLx interface #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halvardssm
commented
Jun 28, 2024
test/test.ts
Outdated
| assertEquals(result7, 12); | ||
| // Releases lock from table. | ||
| stmt.finalize(); | ||
| // TODO figure out why the following error results from this test: |
There was a problem hiding this comment.
@DjDeveloperr Due to changes to FFI, the aggregate test is breaking. After some research, it is due to bigint and number, but I am not completely sure where the error originates. Would you have an idea?
There was a problem hiding this comment.
There are a lot of changes in FFI which would cause type errors mostly - I will make a separate PR for now that takes care of all that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #123
This PR introduces some breaking changes to the Statement class. The Database class is not altered in a breaking way, and a new SQLx file has been introduced.
Changes: