compat: tracking issue for running mocha test case

[kt3k]

This issue tracks the progress of running the test cases of mocha repository.

test.node category

• run nps (task runner used in the repo)
  • find-up doesn't work. compat: tracking issue for running find-up test case #12999
• nps build failed because of zlib.gzip is not available. This can be resolved by feat(node): add mock zlib module std#1698
• npx nps test.node.bdd
• npx nps test.node.tdd
• npx nps test.node.qunit
• npx nps test.node.exports blocked by compat: imported scripts are always handled as ESM #12648
• npx nps test.node.unit
  • blocked by compat: imported scripts are always handled as ESM #12648
  • TypeError: process.allowedNodeEnvironmentFlags is not iterable feat(node): add process.allowedNodeEnvironmentFlags std#2049
  • should not pass if throwing async and test is async
    • https://github.com/mochajs/mocha/blob/ac43029d6a86150a48ccd59e50e89ca10c72a9c0/test/unit/throw.spec.js#L63
    • https://github.com/mochajs/mocha/blob/ac43029d6a86150a48ccd59e50e89ca10c72a9c0/test/unit/throw.spec.js#L111
    • https://github.com/mochajs/mocha/blob/ac43029d6a86150a48ccd59e50e89ca10c72a9c0/test/unit/throw.spec.js#L159
    • These test cases involve uncaught errors and deno can't run these test cases.
  • and other 25 assertion errors (needs investigations)
• npx nps test.node.integration blocked by
  • std/node: Node compatible setTimeout, setInterval std#1622
  • also blocked by missing child_process.fork node: add child_process.fork std#1690
  • blocked by non informative error Error: null
  • Uncaught TypeError: setInterval(...).unref is not a function in mocha/lib/nodejs/parallel-buffered-runner.js fix(node): make global.<timerFunc> Node.js timers std#2038
  • Error: This script is intended to be run as a worker (by the workerpool package) in mocha/lib/nodejs/worker.js
    • workerpool.isMainThread boolean value is wrong
• npx nps test.node.jsapi (2 failures) (related to uncaughtException handler)
  • Still adding/removing event listeners for not implemented events solve this issue chore: warn on non supported event, but still register listener std#2050
• npx nps test.node.requires Module.prototype.load causes Cannot set properties of undefined
• npx nps test.node.reporters
  • blocked by compat: imported scripts are always handled as ESM #12648
  • (20 assertion errors) Needs more investigation
• npx nps test.node.only
  • npx nps test.node.only.bddRequire blocked by compat: imported scripts are always handled as ESM #12648
  • npx nps test.node.only.globalBdd
  • npx nps test.node.only.globalTdd
  • npx nps test.node.only.globalQunit

lint category

• npx nps lint.markdown doesn't work. Mocha depends on an ancient version of markdownlint-cli which depends on an ancient version of Commander which uses __proto__ in inheritance ref: https://github.com/tj/commander.js/blob/v2.3.0/index.js#L94
  • I sent upstream an PR which updates the markdownlint-cli as it's a very old version, and doesn't seem worth support it in node-compat mode (mocha # 4795) Update: PR rejected but the maintainer addressed the issue in another PR
• npx nps lint.code hangs without information. Needs more investigation

Other issus

(These issues need further works to identify what exactly causes them)

• TypeError: Invalid signal: SIGBREAK
• Cannot find module 'https'
• mocha depends on fs-extra, which depends on fs.realpath.native

Known issues which block this task:

• node: process.binding(...) std#1630
• std/node: Node compatible setTimeout, setInterval std#1622
• compat: imported scripts are always handled as ESM #12648
• node: add url.parse std#1666
• compat: tracking issue for running find-up test case #12999
• compat: cjs to esm translation is not applied when a commonjs module is dynamically imported with file:// scheme #13790

ref: #12577

[bartlomieju]

run nps (task runner used in the repo) blocked by std-1633

@kt3k there's no 1633 in deno_std, did you mean 1622 (setTimeout/setInterval)?

[kt3k]

@bartlomieju Oh, it was 1630. The tool nps stops on the error about process.binding('wrap_tty').TTY

$ deno run --compat --unstable -A node_modules/.bin/nps
error: Uncaught (in promise) TypeError: process.binding is not a function
  TTY = process.binding('tty_wrap').TTY,
                ^
    at Object.<anonymous> (file:///Users/kt3k/oss/mocha/node_modules/readline-sync/lib/readline-sync.js:19:17)

[kt3k]

#13553 resolved many issues in mocha compatibility!

[kt3k]

Here https://github.com/mochajs/mocha/blob/d7f6ea5f5d8406204053618c708634dbf5aa9670/lib/nodejs/parallel-buffered-runner.js#L14, mocha shadows setInterval in wrapper function scope with global one. It disables our providing-timers-in-wrapper-function hack 😬

[kt3k]

Maybe we can fake global object using Proxy 🤔

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[kt3k]

I was testing this with the alias node="deno run --compat --unstable", but now the commonjs entrypoint is not supported. So mocha's test case can't be run with the current compat behavior of Deno.

[kt3k]

The major cases like the below seem passing now. Closing as fixed:

deno task test-node:unit
deno task test-node:jsapi
deno task test-node:reporters