-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro error, node 18.17.1 is not supported #21515
Labels
good first issue
Good for newcomers
needs investigation
requires further investigation before determining if it is an issue or not
node API polyfill
Related to various "node:*" modules APIs
node compat
Comments
dsherret
added
needs investigation
requires further investigation before determining if it is an issue or not
node compat
labels
Dec 8, 2023
20 tasks
This should be an easy fix. The version strings need to be updated in this file deno/ext/node/polyfills/_process/process.ts Lines 106 to 137 in 4201f17
|
marvinhagemeister
added a commit
that referenced
this issue
Mar 5, 2024
<!-- Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. --> The issue seems to be already fixed since we upped to a newer 18.x version string in [another PR](#20366). Updating to latest node LTS version can't hurt though. Fixes #21515
littledivy
pushed a commit
that referenced
this issue
Mar 8, 2024
<!-- Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. --> The issue seems to be already fixed since we upped to a newer 18.x version string in [another PR](#20366). Updating to latest node LTS version can't hurt though. Fixes #21515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
needs investigation
requires further investigation before determining if it is an issue or not
node API polyfill
Related to various "node:*" modules APIs
node compat
Version: Deno canary
Repro:
os and setup info:
window 11, wsl - ubuntu, devcontainer - os =
ubuntu
:jammy
, platform =amd64
setup steps
curl -fsSL https://get.pnpm.io/install.sh | sh -
package.json
deno.json
command
Result:
The text was updated successfully, but these errors were encountered: