Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receiveMessageOnPort not implemented in node:worker_threads #22702

Closed
mash-graz opened this issue Mar 5, 2024 · 1 comment · Fixed by #22766
Closed

receiveMessageOnPort not implemented in node:worker_threads #22702

mash-graz opened this issue Mar 5, 2024 · 1 comment · Fixed by #22766
Labels
node compat

Comments

@mash-graz
Copy link
Contributor

mash-graz commented Mar 5, 2024 •
edited
Loading

Version: Deno 1.41.1

As already described in #22629 I need this function for making jco working.

The use of receiveMessageOnPort plays a vital role in the inner working of the rather popular synckit library.

receiveMessageOnPort is really hard to substitute if a runtime does not provide it.
It's the only sync method to share structured data efficiently between workers and main process instance.

I'll try to prepare an implementation attempt for contribution ASAP, although I'm not very familiar with the deno code base and internals, so it may take some time...
@mash-graz mash-graz mentioned this issue Mar 5, 2024
Closed
@mash-graz mash-graz mentioned this issue Mar 7, 2024
Merged
@mash-graz
Copy link
Contributor Author

There is now an implementation PR of this missing method available for review!

bartlomieju pushed a commit that referenced this issue Mar 10, 2024
@mash-graz
fix(ext/node) implement receiveMessageOnPort for node:worker_threads (#…
80dbcd3 
…22766)

Implementation of `receiveMessageOnPort` for `node:worker_threads`

Fixes: #22702
nathanwhit pushed a commit that referenced this issue Mar 14, 2024
@mash-graz @nathanwhit
fix(ext/node) implement receiveMessageOnPort for node:worker_threads (#…
9e49afb 
…22766)

Implementation of `receiveMessageOnPort` for `node:worker_threads`

Fixes: #22702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/node) implement receiveMessageOnPort for node:worker_threads
2 participants
@mash-graz @satyarohith