[deno publish] Unexpected type error with rest parameters and overloads

[rojvv]

Command: deno publish --allow-dirty --dry-run

1.42.2:
zero-code exit

1.42.3:
Fails with the below output:

Check file:///Users/roj/MTKruto/mod.ts
Checking for slow types in the public API...
Check file:///Users/roj/MTKruto/mod.ts
error: Failed ensuring public API type output is valid.

TS1047 [ERROR]: A rest parameter cannot be optional.
  filter(param0?: any, ...param1?: any): any {
                                ^
    at file:///Users/roj/MTKruto/client/1_composer.ts:110:3

You may have discovered a bug in Deno. Please open an issue at: https://github.com/denoland/deno/issues/

The line it links to is

  filter(
    predicate: (ctx: UpdateIntersection<C>) => MaybePromise<boolean>,
    ...middleware: Middleware<UpdateIntersection<C>>[]
  )

...which doesn’t have optional rest parameters, or does it?

[dsherret]

Regression caused by denoland/deno_graph#432 and fixed in denoland/deno_graph#435 (though it was not properly handled before)

We need to add type checking to those tests so we can catch stuff like this.