Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output cause on JS runtime errors #13209

Merged
merged 9 commits into from
Dec 29, 2021
Merged

Conversation

crowlKats
Copy link
Member

Closes #12308

core/error.rs Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member

This looks mostly good to me. @nayeemrmn can you take a look?

core/error.rs Outdated Show resolved Hide resolved
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@crowlKats crowlKats merged commit 167982b into denoland:main Dec 29, 2021
@crowlKats crowlKats deleted the error_cause branch December 29, 2021 18:34
@exe-dealer
Copy link

why this PR not included in 1.17.2 ? @crowlKats

@kitsonk
Copy link
Contributor

kitsonk commented Jan 10, 2022

New features are generally not included in patch release. It will be included in 1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output cause on JS runtime errors
5 participants