feat(node/crypto): Elliptic Curve Diffie-Hellman (ECDH) support #18832
Conversation
levex
changed the title
| "p256", | ||
| "p384", | ||
| "p256 0.11.1", | ||
| "p384 0.11.2", |
There was a problem hiding this comment.
Is it possible to avoid these duplicate dependencies?
There was a problem hiding this comment.
They are not duplicates - each is a pure rust implementation of an elliptic curve.
There was a problem hiding this comment.
Nevermind I see what you mean
| export const ellipticCurves: Array<EllipticCurve> = [ | ||
| { | ||
| name: "secp256k1", | ||
| ephemeral: false, | ||
| privateKeySize: 32, | ||
| publicKeySize: 65, | ||
| sharedSecretSize: 32, | ||
| }, // Weierstrass-class EC used by Bitcoin | ||
| { | ||
| name: "prime256v1", | ||
| ephemeral: true, | ||
| privateKeySize: 32, | ||
| publicKeySize: 65, | ||
| sharedSecretSize: 32, | ||
| }, // NIST P-256 EC | ||
| { | ||
| name: "secp256r1", | ||
| ephemeral: true, | ||
| privateKeySize: 32, | ||
| publicKeySize: 65, | ||
| sharedSecretSize: 32, | ||
| }, // NIST P-256 EC (same as above) | ||
| { | ||
| name: "secp384r1", | ||
| ephemeral: true, | ||
| privateKeySize: 48, | ||
| publicKeySize: 97, | ||
| sharedSecretSize: 48, | ||
| }, // NIST P-384 EC | ||
| { | ||
| name: "secp224r1", | ||
| ephemeral: true, | ||
| privateKeySize: 28, | ||
| publicKeySize: 57, | ||
| sharedSecretSize: 28, | ||
| }, // NIST P-224 EC | ||
| ]; |
There was a problem hiding this comment.
Perhaps as const satisfies Array<EllipticCurve> would be better.
There was a problem hiding this comment.
Because the type becomes clearer. Please see this TS Playground.
There was a problem hiding this comment.
We cannot use Resources to represent curve structures because there is no API to clean up memory.
Please use the exisiting infra for storing key material in JS and passing that to ops.
See https://www.notion.so/denolandinc/node-crypto-design-99fc33f568d24e47a5e4b36002c5325d
Example PR: 9496dfc
| export function getCurves(): readonly string[] { | ||
| notImplemented("crypto.getCurves"); | ||
| return ellipticCurves.map((x) => x.name); | ||
| } |
There was a problem hiding this comment.
const curveNames = ellipticCurves.map((x) => x.name);
export function getCurves(): readonly string[] {
return curveNames;
}
i ran out of tea
third_party
Outdated
levex
changed the title
|
Looks good! Please add / enable Node compat tests for this |
|
Nice work Lev! |
WIP.
Curves:
TODO:
encodingparameter in ECDH classformattingparameter in ECDH classMy gist for testing some of this:
https://gist.github.com/levex/6a22f20eea40e0eb337a02ba906f79d8
(will be updated as the PR progresses)