fix(node): implement createPrivateKey #20981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
changed the title
39 tasks
bartlomieju
reviewed
Nov 6, 2023
| @@ -202,3 +203,28 @@ for (const primeLength of [1024, 2048, 4096]) { | |||
| }, | |||
| }); | |||
| } | |||
|
|
|||
| const rsaPrivateKey = Deno.readTextFileSync( | |||
| new URL("../testdata/rsa_private.pem", import.meta.url), | |||
There was a problem hiding this comment.
This could be import.meta.resolve("../testdata/rsa_private.pem");
There was a problem hiding this comment.
Deno.readTextFileSync does not support the file:// scheme
| // openssl ecparam -name secp256r1 -genkey -noout -out a.pem | ||
| // openssl pkcs8 -topk8 -nocrypt -in a.pem -out b.pem | ||
| const ecPrivateKey = Deno.readTextFileSync( | ||
| new URL("./ec_private_secp256r1.pem", import.meta.url), |
There was a problem hiding this comment.
Discussed offline, we'll enable more native tests once KeyObject support in sign and verify is added (in a follow up).
| } | ||
|
|
||
| export(_options: unknown) { | ||
| notImplemented("crypto.PrivateKeyObject.prototype.export"); |
There was a problem hiding this comment.
Can you open an issue about missing support for PrivateKeyObject.export?
37 tasks
bartlomieju
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #18455