Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FUTURE): terse lockfile (v4) #25059

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 15, 2024

This changes the lockfile to not store versions/version ranges in the npm and jsr package dependencies except when there are duplicate dependencies in the lockfile. This makes it incredibly easy to see when there are duplicate dependencies being used.

  1. Flattens fields to the top level
  2. Doesn't serialize the "remote" field when it's empty
  3. Switches to an array for dependencies for jsr and npm pkgs where it doesn't contain versions unless there's a duplicate dependency in the lockfile.

Example: jsr-io/jsr@453e253

At the moment, this is only behind the DENO_FUTURE=1 environment variable so that we can get feedback on it and find issues.

Closes #23213

@dsherret dsherret marked this pull request as ready for review August 15, 2024 21:38
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments

@dsherret dsherret added this to the 1.46 milestone Aug 19, 2024
@dsherret dsherret enabled auto-merge (squash) August 19, 2024 02:26
@dsherret dsherret merged commit 526f39f into denoland:main Aug 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lockfile v4
2 participants