From a5b147d0659b08bc92217ad0f82bb204beb682d3 Mon Sep 17 00:00:00 2001 From: Andrew Mitchell Date: Sat, 23 May 2020 18:48:31 -0400 Subject: [PATCH 1/7] Issue 1228: Skip 3 fetch tests on windows --- cli/tests/unit/fetch_test.ts | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/cli/tests/unit/fetch_test.ts b/cli/tests/unit/fetch_test.ts index 37fca21123830c..7491ec7ec36fe2 100644 --- a/cli/tests/unit/fetch_test.ts +++ b/cli/tests/unit/fetch_test.ts @@ -367,8 +367,7 @@ function bufferServer(addr: string): Deno.Buffer { unitTest( { - // FIXME(bartlomieju) - ignore: true, + ignore: Deno.build.os === "windows", perms: { net: true }, }, async function fetchRequest(): Promise { @@ -381,6 +380,7 @@ unitTest( ["Foo", "Bar"], ], }); + await response.arrayBuffer(); assertEquals(response.status, 404); assertEquals(response.headers.get("Content-Length"), "2"); @@ -389,6 +389,9 @@ unitTest( "POST /blah HTTP/1.1\r\n", "hello: World\r\n", "foo: Bar\r\n", + "accept: */*\r\n", + `user-agent: Deno/${Deno.version.deno}\r\n`, + "accept-encoding: gzip, br\r\n", `host: ${addr}\r\n\r\n`, ].join(""); assertEquals(actual, expected); @@ -397,8 +400,7 @@ unitTest( unitTest( { - // FIXME(bartlomieju) - ignore: true, + ignore:Deno.build.os === "windows", perms: { net: true }, }, async function fetchPostBodyString(): Promise { @@ -413,6 +415,7 @@ unitTest( ], body, }); + await response.arrayBuffer(); assertEquals(response.status, 404); assertEquals(response.headers.get("Content-Length"), "2"); @@ -421,6 +424,10 @@ unitTest( "POST /blah HTTP/1.1\r\n", "hello: World\r\n", "foo: Bar\r\n", + "content-type: text/plain;charset=UTF-8\r\n", + "accept: */*\r\n", + `user-agent: Deno/${Deno.version.deno}\r\n`, + "accept-encoding: gzip, br\r\n", `host: ${addr}\r\n`, `content-length: ${body.length}\r\n\r\n`, body, @@ -431,8 +438,7 @@ unitTest( unitTest( { - // FIXME(bartlomieju) - ignore: true, + ignore: Deno.build.os === "windows", perms: { net: true }, }, async function fetchPostBodyTypedArray(): Promise { @@ -448,6 +454,7 @@ unitTest( ], body, }); + await response.arrayBuffer(); assertEquals(response.status, 404); assertEquals(response.headers.get("Content-Length"), "2"); @@ -456,6 +463,9 @@ unitTest( "POST /blah HTTP/1.1\r\n", "hello: World\r\n", "foo: Bar\r\n", + "accept: */*\r\n", + `user-agent: Deno/${Deno.version.deno}\r\n`, + "accept-encoding: gzip, br\r\n", `host: ${addr}\r\n`, `content-length: ${body.byteLength}\r\n\r\n`, bodyStr, From 2b0f3e75e4f2d382cc2a1378a6ddb2841e252b59 Mon Sep 17 00:00:00 2001 From: Andrew Mitchell Date: Sat, 23 May 2020 19:00:48 -0400 Subject: [PATCH 2/7] Issue 1228: Fix formatting on fetch_test.ts --- cli/tests/unit/fetch_test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/tests/unit/fetch_test.ts b/cli/tests/unit/fetch_test.ts index 7491ec7ec36fe2..c65cc0b9d6c04c 100644 --- a/cli/tests/unit/fetch_test.ts +++ b/cli/tests/unit/fetch_test.ts @@ -400,7 +400,7 @@ unitTest( unitTest( { - ignore:Deno.build.os === "windows", + ignore: Deno.build.os === "windows", perms: { net: true }, }, async function fetchPostBodyString(): Promise { From fa93ae41723d013cc28e6d8dfc90e0aa6aa59eb9 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Sat, 23 May 2020 21:42:40 -0400 Subject: [PATCH 3/7] bump From 86dcdfd4a2c800631edbc170774befd076bbfde2 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Sat, 23 May 2020 21:43:04 -0400 Subject: [PATCH 4/7] bump2 From 42de8adf59c6f6ac85283309c51b228bdb2b85fa Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Sat, 23 May 2020 21:43:12 -0400 Subject: [PATCH 5/7] bump3 From bf8161a54a84879512ddea567935364937602fd3 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Sun, 24 May 2020 10:01:47 -0400 Subject: [PATCH 6/7] try removing windows restrictions --- cli/tests/unit/fetch_test.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/cli/tests/unit/fetch_test.ts b/cli/tests/unit/fetch_test.ts index c65cc0b9d6c04c..458c34ae23dc1e 100644 --- a/cli/tests/unit/fetch_test.ts +++ b/cli/tests/unit/fetch_test.ts @@ -367,7 +367,6 @@ function bufferServer(addr: string): Deno.Buffer { unitTest( { - ignore: Deno.build.os === "windows", perms: { net: true }, }, async function fetchRequest(): Promise { @@ -400,7 +399,6 @@ unitTest( unitTest( { - ignore: Deno.build.os === "windows", perms: { net: true }, }, async function fetchPostBodyString(): Promise { @@ -438,7 +436,6 @@ unitTest( unitTest( { - ignore: Deno.build.os === "windows", perms: { net: true }, }, async function fetchPostBodyTypedArray(): Promise { From 736b00954c2ccd297286c66eb2b0158a4913bf5d Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Sun, 24 May 2020 10:02:21 -0400 Subject: [PATCH 7/7] bump4