Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove support for comments in 'tasks' option #136

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

bartlomieju
Copy link
Member

#129 will add support for
defining tasks using object notation and support description field,
which renders support for comments in tasks not needed. This greatly
simplifies the code.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
bartlomieju Bartek Iwańczuk
@bartlomieju bartlomieju requested a review from dsherret November 14, 2024 16:59
pub struct ConfigParseOptions {
pub include_task_comments: bool,
}
pub struct ConfigParseOptions {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I elected to keep this struct to not introduce a lot of changes to the signatures and in the future we might want to have other options.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 394d5f0 into main Nov 14, 2024
4 checks passed
@bartlomieju bartlomieju deleted the remove_task_comments branch November 14, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants