Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add range to assertion type error #213

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 6, 2023

In graph_util.rs in the CLI there is a concept of a "referrer_map" that looks error prone. Instead we should store the range information in the error itself.

@dsherret dsherret requested a review from bartlomieju February 6, 2023 16:37
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 9ed76fa into denoland:main Feb 6, 2023
@dsherret dsherret deleted the fix_add_range_to_assertion_error branch February 6, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants