Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move invalid local import and downlevel errors to validate method #233

Merged
merged 4 commits into from
Feb 15, 2023
Merged

feat: move invalid local import and downlevel errors to validate method #233

merged 4 commits into from
Feb 15, 2023

Conversation

dsherret
Copy link
Member

This is to have better deno vendor support. I'm seeing some more refactors we could do in deno_graph we should do after doing this.

@dsherret dsherret requested a review from bartlomieju February 15, 2023 01:16
bartlomieju
bartlomieju approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments

@dsherret dsherret merged commit 50f6e72 into denoland:main Feb 15, 2023
@dsherret dsherret deleted the fix_use_same_behaviour_resolver branch February 15, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju