New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check all import ranges in Dependency::includes() #271

Merged

dsherret merged 3 commits into denoland:main from nayeemrmn:dependency-includes-imports

Apr 23, 2023

Collaborator

nayeemrmn commented Apr 23, 2023

This is preventing the LSP hover text on repeated imports from including certain dependency information: https://github.com/denoland/deno/blob/5a524a9a5a7fac0d16b2cbe2df1142dc419df7fc/cli/lsp/documents.rs#L603.


          fix: check all import ranges in Dependency::includes()

5b7d306

dsherret approved these changes

View reviewed changes

Member

dsherret left a comment

LGTM. I will kick off a patch release after merging

nayeemrmn added 2 commits

April 23, 2023 23:15


          lint

6c7c4b2


          lint

c3ef1ba

dsherret merged commit 5b79b66 into denoland:main

nayeemrmn deleted the dependency-includes-imports branch

April 23, 2023 22:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet