Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load JSR URLs using checksum found in package's manifest #380

Merged
merged 11 commits into from
Feb 15, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 14, 2024

This loads individual files in the package using the checksum found in the package's manifest. This allows us to reduce the amount of information we need to store in the lockfile.

@dsherret dsherret marked this pull request as ready for review February 14, 2024 21:45
@dsherret dsherret requested a review from mmastrac February 14, 2024 21:45
@dsherret dsherret changed the title feat: load JSR dependencies using package manifest's checksum feat: load JSR URLs using checksum found in package's manifest Feb 14, 2024
Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 761dc33 into denoland:main Feb 15, 2024
4 checks passed
@dsherret dsherret deleted the feat_load_jsr_deps_with_checksum branch February 15, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants